fix(dataconnect): fix deserialization of emulator gRPC error codes into detailed errors#3180
Open
stephenarosaj wants to merge 2 commits into
Open
fix(dataconnect): fix deserialization of emulator gRPC error codes into detailed errors#3180stephenarosaj wants to merge 2 commits into
stephenarosaj wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for handling gRPC-to-HTTP transcoded error responses in the Data Connect API client by mapping numeric gRPC status codes to their string equivalents. It also updates .gitignore to exclude local debug logs and adds a unit test to verify the new error-handling behavior. A critical issue was identified in the error parsing logic where a null error property in the response could lead to a TypeError and crash the error-handling flow; a code suggestion was provided to safely handle this scenario.
|
ultranit: looks like there may be some mismatched backticks in the PR description (see attached screenshot) 
|
dconeybe
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
✨ Added gRPC status code mapping to ensure error responses from the local Data Connect emulator are correctly deserialized. Before these changes, when using the emulator, errors are improperly deserialized into
DataConnectErrors withunknown-errorinstead of ones with detailedcodeandmessagefields.Verified by running the integration tests against the emulator (and production) before and after the changes. What was broken is now fixed!
Changes
GRPC_STATUS_CODE_TO_STRINGmapping dictionarytoFirebaseErrorto handle root-level gRPC error responses.gitignoreTesting