Skip to content

[Deploy preview] Add a function list #5233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mstange wants to merge 32 commits into
base: main
Choose a base branch
from
Draft

[Deploy preview] Add a function list #5233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
b7fd9c3
Implement column sorting in the generic TreeView.
mstange Mar 31, 2026
d17fade
Implement column sorting in the marker table.
mstange Mar 31, 2026
f5f2c06
Split getSelfAndTotal.
mstange Mar 31, 2026
55a1bd2
Add a function list panel.
mstange Nov 27, 2024
080d0ed
Implement activity graph highlighting for function list
mstange Apr 3, 2026
f28c226
Implement function list context menu.
mstange Apr 3, 2026
832a90f
Implement transform shortcut keys for function list
mstange Apr 3, 2026
0748425
Scroll selection into view when applying/unapplying transforms
mstange Apr 3, 2026
ffb2fb3
Select self function when clicking in the activity graph
mstange Apr 3, 2026
edc8324
Select first row in the function list on mount.
mstange Apr 4, 2026
c26277c
Implement double-clicking to show the bottom box in the function list.
mstange Apr 4, 2026
bbd6d34
Pass callNodeInfo to handleCallNodeTransformShortcut.
mstange Mar 30, 2026
4fdb25b
Add inverted butterfly wing.
mstange Mar 30, 2026
c33fafb
Add context menu for inverted wing
mstange Apr 4, 2026
7396730
Add the upper butterfly wing.
mstange Mar 30, 2026
c753e6e
Fix splitter styling
mstange Mar 31, 2026
0134eef
First attempt at FlameGraph refactor
mstange Apr 2, 2026
3c07b77
Upper wing is now a flame graph
mstange Apr 2, 2026
6169367
Add self wing
mstange Apr 2, 2026
2afabc0
Add disclosure box
mstange Apr 2, 2026
fbdb44b
Remove horizontal splitters, just use disclosure boxes.
mstange Apr 3, 2026
62687ae
Fix flamegraph percentages for the function list subtree views.
mstange Apr 3, 2026
ff9b733
Fix double-click opening source view and context menus in butterfly w…
mstange Apr 9, 2026
e5bfed9
Implement context menu for self wing
mstange Apr 14, 2026
5e5041d
Persist disclosure box state in the URL.
mstange May 7, 2026
3143955
Persist selected function in the URL.
mstange May 7, 2026
811d719
Make it so the replaceState idea actually works.
mstange May 8, 2026
4e4b583
Add some comments about the lower wing.
mstange Jun 16, 2026
5918a15
Eagerly compute lower wing callnode info.
mstange Jun 16, 2026
d28879e
Make the lower wing a flame graph, too.
mstange Jun 17, 2026
6362631
Add buttons to switch between flame graph and call tree on the upper/…
mstange Jun 17, 2026
df3e3bd
Add those buttons for the self wing too.
mstange Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions locales/en-US/app.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,6 +900,7 @@ StackSettings--panel-search =
## Tab Bar for the bottom half of the analysis UI.

TabBar--calltree-tab = Call Tree
TabBar--function-list-tab = Function List
TabBar--flame-graph-tab = Flame Graph
TabBar--stack-chart-tab = Stack Chart
TabBar--marker-chart-tab = Marker Chart
Expand Down
3 changes: 2 additions & 1 deletion res/css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ body {
flex-shrink: 1;
}

.treeAndSidebarWrapper {
.treeAndSidebarWrapper,
.functionTableAndSidebarWrapper {
display: flex;
flex: 1;
flex-flow: column nowrap;
Expand Down
Loading
Loading