feature/exchange-gain-loss#215
Open
fivetran-catfritz wants to merge 6 commits into
Open
Conversation
fivetran-savage
approved these changes
Jun 30, 2026
fivetran-savage
left a comment
fivetran-savage
left a comment
Contributor
There was a problem hiding this comment.
Just one question about the changelog but nothing to hold off approval for a pre-release.
| | `quickbooks__general_ledger`<br>`quickbooks__general_ledger_by_period` | New records | — | Exchange gain/loss entries | | | ||
|
|
||
| ## Feature Update | ||
| - Adds realized exchange gain/loss entries to `int_quickbooks__bill_payment_double_entry` and `int_quickbooks__payment_double_entry` to capture the currency impact when a foreign currency transaction is settled at a different exchange rate than when it was originally recorded. Requires an `ExchangeGainOrLoss` account in QuickBooks to generate entries. |
Contributor
There was a problem hiding this comment.
In the validation, it appears to be both an account_name value and an account_sub_type value. Do we need to call that out explicitly?
Contributor
Author
There was a problem hiding this comment.
Good question. It's the account_sub_type that is a pre-set list coming from Quickbook, and the name should follow, so yes I should clarify what field we're talking about here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
int_quickbooks__bill_payment_double_entryandint_quickbooks__payment_double_entryto capture the currency impact when a foreign currency transaction is settled at a different exchange rate than when it was originally recorded. Requires anExchangeGainOrLossaccount in QuickBooks to generate entries.Submission Checklist
Changelog