feat(cli): render API timestamps as RFC3339 in structured output#21
Closed
ysyneu wants to merge 1 commit into
Closed
feat(cli): render API timestamps as RFC3339 in structured output#21ysyneu wants to merge 1 commit into
ysyneu wants to merge 1 commit into
Conversation
Flashduty's API returns time fields as bare Unix integers, which are opaque to an LLM reading the CLI's JSON/TOON output. Humanize them to RFC3339 (in the local/environment timezone) at the structured-output chokepoints — JSONPrinter, TOONPrinter, and marshalStructured. Detection is by field name (*_time, *_at, timestamp), excluding ID-like fields (*_by/*_id/*_ids); values below 1e9 stay numeric so durations/counts aren't mistaken for dates. Table mode is unchanged (already formats via FormatTime).
Contributor
Author
|
Superseded by #23 (rebased onto the merged SDK timestamp design; scoped to SDK adoption, Makefile left untouched). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JSONPrinter,TOONPrinter, andmarshalStructured.*_time,*_at,timestamp), excluding ID-like fields (*_by/*_id/*_ids); values below1e9stay numeric so durations/counts aren't mistaken for dates;>=1e12is treated as millis.FormatTime). Theflashduty-sdkis intentionally untouched — external users consume it directly.Test plan
go test ./...greenJSONPrinter/TOONPrinterand assert no raw Unix int leaksgofmt/go vetclean