filter_logs_to_metrics: document field_value usage for counters#1584
filter_logs_to_metrics: document field_value usage for counters#1584databus23 wants to merge 5 commits into
Conversation
This documents a feature added with this PR: fluent/fluent-bit#10055 Signed-off-by: Fabian Ruff <fabian.ruff@sap.com>
alexakreizinger
left a comment
There was a problem hiding this comment.
hi @databus23, thanks for submitting a docs PR! I just suggested a few edits for clarity and consistency.
Co-authored-by: Alexa Kreizinger <alexakreizinger@gmail.com> Signed-off-by: Fabian Ruff <fabian@progra.de>
|
@alexakreizinger thanks for the feedback. I merged in all your suggestions. |
alexakreizinger
left a comment
There was a problem hiding this comment.
awesome, thank you :) I'm approving this, but I won't merge anything since it sounds like we're still waiting on a different code PR—feel free to merge this one when the time comes.
|
@databus23 can you resolve the conflicts please as I've also nudged the review on code PR fluent/fluent-bit#10055, so I can merge this when it's ready? |
|
The conflicts were due to formatting changes for style, I went ahead and fixed the conflicts in the interest of keeping things moving. |
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com> Signed-off-by: Eric D. Schabell <eric@schabell.org>
347ee6f to
15ea4a6
Compare
|
Caution Review failedFailed to post review comments 📝 WalkthroughWalkthroughDocumentation for the Fluent Bit Changeslog_to_metrics Counter Example
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
pipeline/filters/log_to_metrics.md (1)
155-155:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winFix typo in metric HELP text.
time spendshould betime spentto match the configured description and avoid confusion.Suggested fix
-# HELP log_metric_counter_total_duration This metric counts the total time spend +# HELP log_metric_counter_total_duration This metric counts the total time spent🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pipeline/filters/log_to_metrics.md` at line 155, Update the HELP text for the Prometheus metric named log_metric_counter_total_duration to correct the typo "time spend" → "time spent" (edit the HELP line in pipeline/filters/log_to_metrics.md so the description matches the configured description and reads "This metric counts the total time spent").
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pipeline/filters/log_to_metrics.md`:
- Around line 110-117: The YAML/classic examples are out of sync: add the same
counter configuration shown in the fluent-bit.conf example to the
fluent-bit.yaml/classic example so outputs match; specifically ensure the filter
named log_to_metrics includes metric_mode: counter, metric_name: total_duration,
metric_description and value_field: duration (mirror the total_duration counter
definition present in the conf example) so the sample output lines that show
both counters are reproducible.
---
Duplicate comments:
In `@pipeline/filters/log_to_metrics.md`:
- Line 155: Update the HELP text for the Prometheus metric named
log_metric_counter_total_duration to correct the typo "time spend" → "time
spent" (edit the HELP line in pipeline/filters/log_to_metrics.md so the
description matches the configured description and reads "This metric counts the
total time spent").
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a696f61e-a519-4fa9-b060-95895dacadbc
📒 Files selected for processing (1)
pipeline/filters/log_to_metrics.md
…ounter examples
- Add total_duration counter filter to fluent-bit.yaml example to match
fluent-bit.conf
- Fix indentation in second [FILTER] block from 4-space to 2-space
- Apply Title_Case to all keys in the classic conf counter example
Applies to fluent#1584
Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
Actionable comments posted: 0 |
Signed-off-by: Eric D. Schabell <eric@schabell.org>
eschabell
left a comment
There was a problem hiding this comment.
@databus23 waiting now on code PR merging.
This documents a feature added with this PR: fluent/fluent-bit#10055
Summary by CodeRabbit