Skip to content

Allow individual skills to be specified in dart_skills_lint.yaml#167

Merged
reidbaker merged 12 commits into
flutter:mainfrom
reidbaker:issue-166
Jun 18, 2026
Merged

Allow individual skills to be specified in dart_skills_lint.yaml#167
reidbaker merged 12 commits into
flutter:mainfrom
reidbaker:issue-166

Conversation

@reidbaker-agent

@reidbaker-agent reidbaker-agent commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Fixes #166
add changelog entry adding to the definition-of-done
Add dart format and analyze to reidbaker-agent persona.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@reidbaker reidbaker self-requested a review June 17, 2026 21:50

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for configuring individual skills via the individual_skills key in dart_skills_lint.yaml, allowing path-specific rule severity mapping without relying on root directory scanning. It refactors ConfigParser to use a shared helper _parseConfigList (renaming DirectoryConfig to LintTargetConfig), adds validation to prevent overlapping paths between directories and individual skills, and updates documentation and tests accordingly. Feedback on this PR highlights a critical bug in entry_point.dart where passing effectiveIndividualSkillPaths to _getEffectiveSkillDirPaths inadvertently skips the fallback logic for configured directories. Additionally, it is recommended to improve the error messages in _parseConfigList by dynamically labeling entries instead of hardcoding 'Directory entry' to avoid confusing users when errors occur under the individual_skills configuration.

Comment thread tool/dart_skills_lint/lib/src/entry_point.dart
Comment thread tool/dart_skills_lint/lib/src/config_parser.dart
@reidbaker

Copy link
Copy Markdown
Contributor

/gemini-review

@reidbaker reidbaker merged commit 8f85e82 into flutter:main Jun 18, 2026
13 checks passed
@reidbaker reidbaker deleted the issue-166 branch June 18, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[dart_skills_lint] Support individual skills in dart_skills_lint.yaml

2 participants