Allow individual skills to be specified in dart_skills_lint.yaml#167
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for configuring individual skills via the individual_skills key in dart_skills_lint.yaml, allowing path-specific rule severity mapping without relying on root directory scanning. It refactors ConfigParser to use a shared helper _parseConfigList (renaming DirectoryConfig to LintTargetConfig), adds validation to prevent overlapping paths between directories and individual skills, and updates documentation and tests accordingly. Feedback on this PR highlights a critical bug in entry_point.dart where passing effectiveIndividualSkillPaths to _getEffectiveSkillDirPaths inadvertently skips the fallback logic for configured directories. Additionally, it is recommended to improve the error messages in _parseConfigList by dynamically labeling entries instead of hardcoding 'Directory entry' to avoid confusing users when errors occur under the individual_skills configuration.
|
/gemini-review |
Fixes #166
add changelog entry adding to the definition-of-done
Add dart format and analyze to reidbaker-agent persona.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.