feat: add Prometheus counter for dropped subscriber updates#7643
Open
falloficaruss wants to merge 3 commits into
Open
feat: add Prometheus counter for dropped subscriber updates#7643falloficaruss wants to merge 3 commits into
falloficaruss wants to merge 3 commits into
Conversation
Track dropped updates via a counter in the ActionsClient so administrators can monitor subscriber channel capacity. Signed-off-by: Abhishek Shinde <norizzabhii@gmail.com>
Signed-off-by: Abhishek Shinde <139879930+falloficaruss@users.noreply.github.com>
Signed-off-by: Abhishek Shinde <norizzabhii@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #7641
Why are the changes needed?
Currently, when a subscriber channel is full, dropped updates are only logged at the
Warnflevel. This makes it difficult to detect chronic subscriber backpressure in production — logs are ephemeral, and there is no metric to alert on.Adding a Prometheus counter allows operators to:
What changes were proposed in this pull request?
This PR adds a
dropped_updatesPrometheus counter to theActionsClientstruct inactions/k8s/client.go:droppedUpdates prometheus.Counteradded to theActionsClientstruct.scope.MustNewCounter("dropped_updates", ...)inNewActionsClient.c.droppedUpdates.Inc()is called in thedefaultbranch of the subscriber notificationselect, right before the existingWarnflog.No behavioral changes beyond the metric emission. All existing tests continue to pass.
How was this patch tested?
Existing tests (TestSubscribeIsScopedByRun, TestUnsubscribeScopedByRun) call c.notifySubscribers directly with buffered channels that never fill, so they never hit the default branch and the nil counter is unreachable, they continue to pass.
Labels
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Stack
If you do use
git townto manage PR Stacks, the stack relevant to this PRwill show below. Otherwise, you can ignore this section.
Docs link