Skip to content

MODEXPW-625 - Update folio-export-common#378

Merged
SerhiiNosko merged 2 commits into
masterfrom
MODEXPW-625
Jun 17, 2026
Merged

MODEXPW-625 - Update folio-export-common#378
SerhiiNosko merged 2 commits into
masterfrom
MODEXPW-625

Conversation

@markusweigelt

Copy link
Copy Markdown
Contributor

MODEXPW-625
- Send the export by email

Purpose

Update submodule to include schema changes

@markusweigelt markusweigelt requested a review from a team May 27, 2026 12:24
Comment thread .gitmodules Outdated
path = folio-export-common
url = https://github.com/folio-org/folio-export-common.git
url = https://github.com/slub/folio-export-common.git
branch = MODEXPW-625

@SerhiiNosko SerhiiNosko Jun 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ModuleDescriptor-template is also should be updated.

It is for synchronous invocations:
/data-export-spring/jobs/send with permissions:
"email.message.post"
"template-request.post"

/data-export-spring/jobs
"email.message.post"
"template-request.post"

and for asynchronous triggered by Quartz:
For system user for Eureka-based envs:
"metadata": {
"user": {
"type": "system",
"permissions": [

"email.message.post"
"template-request.post"

and for system user for Okapi based envs:
add these 2 permissions into system-user-permissions.csv

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SerhiiNosko Only updating the pointer to folio-export-common is necessary here, so the .gitmodules change is no longer needed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and waht about permissions, I mean add permissions to call template services to system user?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I overlooked that in the heat of the moment. Thanks for following up. 👍🏻

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The system user permissions are now included.

The export job's outbound calls to mod-email and mod-template-engine
reuse mod-data-export-spring's system-user token forwarded over Kafka,
so that token must carry email.message.post and template-request.post.
@sonarqubecloud

Copy link
Copy Markdown

@SerhiiNosko SerhiiNosko merged commit 696b193 into master Jun 17, 2026
17 checks passed
@markusweigelt markusweigelt deleted the MODEXPW-625 branch June 18, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants