fix(eHoldings-loading): fix offset handling when retrieving holdings from HoldingsIQ#686
Merged
Conversation
|
psmagin
approved these changes
Jun 22, 2026
viacheslavkol
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Purpose
The offset value is treated as a page number (1, 2, 3, ...) rather than a record position. This causes each request to retrieve an almost identical set of records, resulting in significant overlap between pages. Because nearly the same records are returned on every request, only a small subset of holdings is repeatedly processed and saved to holdings table, while the vast majority of holdings are never retrieved from the API.
Approach
offsetparameter as a 1-based record position when retrieving holdings from the HoldingsIQ APIFor example:
offset=1 → records 1–2500offset=2501 → records 2501–5000publisher_namecolumn size in theholdingstable to 250 characters to prevent the following error:PgException: ERROR: value too long for type character varying(200)Changes Checklist
Related Issues
MODKBEKBJ-825