Skip to content

fix(eHoldings-loading): fix offset handling when retrieving holdings from HoldingsIQ#686

Merged
SvitlanaKovalova1 merged 4 commits into
masterfrom
MODKBEKBJ-825
Jun 22, 2026
Merged

fix(eHoldings-loading): fix offset handling when retrieving holdings from HoldingsIQ#686
SvitlanaKovalova1 merged 4 commits into
masterfrom
MODKBEKBJ-825

Conversation

@SvitlanaKovalova1

@SvitlanaKovalova1 SvitlanaKovalova1 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Purpose

The offset value is treated as a page number (1, 2, 3, ...) rather than a record position. This causes each request to retrieve an almost identical set of records, resulting in significant overlap between pages. Because nearly the same records are returned on every request, only a small subset of holdings is repeatedly processed and saved to holdings table, while the vast majority of holdings are never retrieved from the API.

Approach

  • use the offset parameter as a 1-based record position when retrieving holdings from the HoldingsIQ API
    For example:
    offset=1 → records 1–2500
    offset=2501 → records 2501–5000
  • Increase the publisher_name column size in the holdings table to 250 characters to prevent the following error:
    PgException: ERROR: value too long for type character varying(200)
image

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

MODKBEKBJ-825

@sonarqubecloud

Copy link
Copy Markdown

@SvitlanaKovalova1 SvitlanaKovalova1 marked this pull request as ready for review June 22, 2026 07:27
@SvitlanaKovalova1 SvitlanaKovalova1 requested a review from a team as a code owner June 22, 2026 07:27
@SvitlanaKovalova1 SvitlanaKovalova1 merged commit 8755191 into master Jun 22, 2026
16 checks passed
@SvitlanaKovalova1 SvitlanaKovalova1 deleted the MODKBEKBJ-825 branch June 22, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants