OKAPI-1228: Add javadoc about ServicesResourceTransformer requirement#1425
Merged
Conversation
If some other dependency also ships with io.vertx.core.spi.VertxServiceProvider we need to execute maven-shade-plugin with ServicesResourceTransformer that concatenated both files. Otherwise we may get an excpetion in org.folio.okapi.common.logging.FolioLoggingContext.put, see folio-org/mod-copycat#123
julianladisch
requested review from
KaterynaSenchenko,
RuslanLavrov,
adamdickmeiss,
barbaraloehle and
steveellis
RuslanLavrov
approved these changes
Nov 20, 2025
KaterynaSenchenko
approved these changes
Nov 20, 2025
adamdickmeiss
requested changes
Nov 21, 2025
adamdickmeiss
left a comment
adamdickmeiss
left a comment
Contributor
There was a problem hiding this comment.
Text ok, but needs fixing due to checkstyle errors.
julianladisch
force-pushed
the
OKAPI-1228
branch
from
9a2cb01 to
5024984
Compare
adamdickmeiss
approved these changes
Dec 3, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If some other dependency also ships with io.vertx.core.spi.VertxServiceProvider we need to execute maven-shade-plugin with ServicesResourceTransformer that concatenated both files.
Otherwise we may get an exception in org.folio.okapi.common.logging.FolioLoggingContext.put, see folio-org/mod-copycat#123