made configuration labels in-line#27
Open
MrAtomicBombHead wants to merge 1 commit into
Open
Conversation
AlexKempen
requested changes
Jul 13, 2026
AlexKempen
left a comment
AlexKempen
left a comment
Collaborator
There was a problem hiding this comment.
Looks pretty good, some minor tweaks/enhancements
| onValueChange(checked ? "true" : "false") | ||
| )} | ||
| /> | ||
| <Group gap="sm" align="center" mt="sm"> |
Collaborator
There was a problem hiding this comment.
I actually think the existing checkbox implementation was pretty good and is fairly representative of what we should be aiming for in terms of styling
| onChange={(event) => onValueChange(event.currentTarget.value)} | ||
| /> | ||
| <Group gap="sm" align="center" mt="sm"> | ||
| <Text size="sm" style={{ minWidth: "120px", flexShrink: 0 }}> |
Collaborator
There was a problem hiding this comment.
I think removing minWidth to more closely match the existing inputs would be good
| }} | ||
| /> | ||
| <Group gap="sm" align="center" mt="sm"> | ||
| <Text size="sm" style={{ minWidth: "120px", flexShrink: 0 }}> |
Collaborator
There was a problem hiding this comment.
If you add component="label" and htmlFor={parameter.id}, you can link the text to the select so clicking the text also activates the select (this also applies to the other components)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the labels for configuration windows from above the input box to the left of it so they are in-line.