Release Update#23
Merged
Merged
Conversation
Lets users choose, via SEL CWS connection parameters, between the rolling
sliding DFT estimator (optional EMA smoothing, default) and the IEEE
C37.118-2018 Annex D filter-based estimator (P/M class); brings Gemstone
back in sync with the GSF implementation.
- Shared PhaseEstimate/PhaseEstimateHandler + IPhaseEstimator; new
PhaseEstimationAlgorithm { SlidingDft, IEEEC37_118 } enum
- SlidingDftPhaseEstimator + IEEEC37_118PhaseEstimator replace
RollingPhaseEstimator; both use VA,VB,VC,IA,IB,IC order (completes the
voltage/current alignment, fixing the IEEE positive-sequence indexing)
- ConnectionParameters: Algorithm selector + sliding-DFT options grouped
into General / Sliding DFT / IEEE C37.118 property categories
- FrameParser builds the selected estimator, rebuilding on parameter change
- Replaced the console demo with MSTest unit tests (9 sliding DFT + 6 IEEE)
…tructor or destructor' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
The initial CWS data frame spans 48 bytes: 16-byte common header + 8-byte nanosecond timestamp + first 24-byte sample. ParseFrame advanced only 32 (timestamp + first sample) before parsing the remaining 49 samples, omitting the common header. This read samples 1-49 of every packet 16 bytes (4 analog channels) too early, scrambling channel/sample alignment -- only the first sample of each 50-sample packet was correct -- and corrupting derived phase estimates. Advance offset/length by 48 instead of 32 so all 50 samples align and sample 49 ends exactly at the 1224-byte frame boundary. On-wire framing and the voltage-first channel order (VA,VB,VC,IA,IB,IC) were already correct.
SEL CWS: user-selectable sliding-DFT and IEEE C37.118 phase estimation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was Generated by a release of openHistorian