fix(spans): Copy user sentry_tags into conventional attributes#6030
Merged
Conversation
3 tasks
mjq
force-pushed
the
mjq/copy-user-sentry-tags-to-conventional-attrs
branch
2 times, most recently
from
d857799 to
dcfb6b4
Compare
mjq
added a commit
to getsentry/sentry-conventions
that referenced
this pull request
May 29, 2026
V1 spans write user information to `sentry.user.`-prefixed attributes instead of our conventional attributes. (With getsentry/relay#6030 we will start writing them to their conventional names as well going forward, but that doesn't help for backward compatibility.) V2 spans only have the new, conventional attribute names. But, Sentry is currently still querying for the old `sentry.user.`-prefixed ones. By adding these deprecated attributes, EAP will start coalescing queries to handle either attribute name. This will fix user attribute searches for V2 spans and give us backwards compatibility as we switch everything over to use the new conventional names. Note that `_status: null` is fine for the deprecations - `backfill`, etc are only used by the v2 pipeline, and v2 spans never have these deprecated attributes. Fixes #405, CON-95. --- 🤖: Used Claude Code (Opus 4.6) to help generate the JSON. Reviewed by hand. Words my own.
loewenheim
approved these changes
Jun 1, 2026
mjq
force-pushed
the
mjq/copy-user-sentry-tags-to-conventional-attrs
branch
from
21a28d1 to
f6503ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the user attributes in
sentry_tagshave new conventional attributes without thesentry.prefix. User attributes are used during ingestion (segment enrichment copies them from segment spans to children) so having EAP coalesce queries via deprecations alone isn't enough, we need to actually copy them.Once everything is straightened out we might be able to stop writing the old
sentry.names, but currently Sentry depends on them.Fixes INGEST-935.
🤖 : Claude Code (Opus 4.6) used to generate some of the code. Carefully human reviewed. Words my own.