feat: add build flags for enabling a KSCrash Integration#8154
Draft
NinjaLikesCheez wants to merge 6 commits into
Draft
feat: add build flags for enabling a KSCrash Integration#8154NinjaLikesCheez wants to merge 6 commits into
NinjaLikesCheez wants to merge 6 commits into
Conversation
Contributor
|
📲 Install BuildsiOS
|
bacb72f to
df46061
Compare
df46061 to
af63656
Compare
Contributor
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 71e6611 | 1213.27 ms | 1242.25 ms | 28.98 ms |
| 2446b3d | 1218.36 ms | 1253.98 ms | 35.62 ms |
| 86bd73c | 1232.52 ms | 1269.53 ms | 37.01 ms |
| bf10fe6 | 1226.00 ms | 1260.76 ms | 34.76 ms |
| 5804f33 | 1208.40 ms | 1241.33 ms | 32.93 ms |
| 379d045 | 1210.00 ms | 1241.24 ms | 31.24 ms |
| a781a3d | 1210.98 ms | 1244.31 ms | 33.33 ms |
| a48979e | 1244.58 ms | 1269.00 ms | 24.42 ms |
| 151b3ee | 1238.69 ms | 1270.73 ms | 32.05 ms |
| 36c25b3 | 1229.10 ms | 1255.83 ms | 26.73 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 71e6611 | 24.14 KiB | 1.15 MiB | 1.12 MiB |
| 2446b3d | 24.14 KiB | 1.17 MiB | 1.15 MiB |
| 86bd73c | 24.14 KiB | 1.16 MiB | 1.13 MiB |
| bf10fe6 | 24.14 KiB | 1.17 MiB | 1.15 MiB |
| 5804f33 | 24.14 KiB | 1.18 MiB | 1.16 MiB |
| 379d045 | 24.14 KiB | 1.18 MiB | 1.15 MiB |
| a781a3d | 24.14 KiB | 1.16 MiB | 1.13 MiB |
| a48979e | 24.14 KiB | 1.17 MiB | 1.15 MiB |
| 151b3ee | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| 36c25b3 | 24.14 KiB | 1.18 MiB | 1.16 MiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Introduce a new
ENABLE_KSCRASHSPM trait/build flag that gates:💡 Motivation and Context
This allows us to start fleshing out a KSCrash integration without affecting consumers of the SDK (i.e. they won't download the dependency and it won't be included in their build). Likewise, this will allow developers to work on V10 without having to enable an in-flight KSCrash integration.
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.#skip-changelog