Skip to content

feat: add build flags for enabling a KSCrash Integration#8154

Draft
NinjaLikesCheez wants to merge 6 commits into
mainfrom
kscrash-compiler-flag
Draft

feat: add build flags for enabling a KSCrash Integration#8154
NinjaLikesCheez wants to merge 6 commits into
mainfrom
kscrash-compiler-flag

Conversation

@NinjaLikesCheez

Copy link
Copy Markdown
Member

📜 Description

Introduce a new ENABLE_KSCRASH SPM trait/build flag that gates:

  • Fetching of KSCrash dependency
  • Compilation of Sentry KSCrash Integration instead of SentryCrash Integration

💡 Motivation and Context

This allows us to start fleshing out a KSCrash integration without affecting consumers of the SDK (i.e. they won't download the dependency and it won't be included in their build). Likewise, this will allow developers to work on V10 without having to enable an in-flight KSCrash integration.

💚 How did you test it?

  • Builds passing
  • Existing tests passing
  • CI Passing

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • If I added a new public API, I also added it to the SentryObjC wrapper.

#skip-changelog

@NinjaLikesCheez NinjaLikesCheez added the ready-to-merge Use this label to trigger all PR workflows label Jun 23, 2026
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 93c1b68

@sentry

sentry Bot commented Jun 23, 2026

Copy link
Copy Markdown

📲 Install Builds

iOS

🔗 App Name App ID Version Configuration
SDK-Size io.sentry.sample.SDK-Size 9.19.0 (1) Release

⚙️ sentry-cocoa Build Distribution Settings

@NinjaLikesCheez NinjaLikesCheez self-assigned this Jun 25, 2026
@NinjaLikesCheez NinjaLikesCheez force-pushed the kscrash-compiler-flag branch from bacb72f to df46061 Compare June 25, 2026 08:40
@NinjaLikesCheez NinjaLikesCheez force-pushed the kscrash-compiler-flag branch from df46061 to af63656 Compare June 25, 2026 08:55
@github-actions

Copy link
Copy Markdown
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • .github/file-filters.yml

@github-actions

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.72 ms 1258.86 ms 36.14 ms
Size 24.14 KiB 1.22 MiB 1.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
71e6611 1213.27 ms 1242.25 ms 28.98 ms
2446b3d 1218.36 ms 1253.98 ms 35.62 ms
86bd73c 1232.52 ms 1269.53 ms 37.01 ms
bf10fe6 1226.00 ms 1260.76 ms 34.76 ms
5804f33 1208.40 ms 1241.33 ms 32.93 ms
379d045 1210.00 ms 1241.24 ms 31.24 ms
a781a3d 1210.98 ms 1244.31 ms 33.33 ms
a48979e 1244.58 ms 1269.00 ms 24.42 ms
151b3ee 1238.69 ms 1270.73 ms 32.05 ms
36c25b3 1229.10 ms 1255.83 ms 26.73 ms

App size

Revision Plain With Sentry Diff
71e6611 24.14 KiB 1.15 MiB 1.12 MiB
2446b3d 24.14 KiB 1.17 MiB 1.15 MiB
86bd73c 24.14 KiB 1.16 MiB 1.13 MiB
bf10fe6 24.14 KiB 1.17 MiB 1.15 MiB
5804f33 24.14 KiB 1.18 MiB 1.16 MiB
379d045 24.14 KiB 1.18 MiB 1.15 MiB
a781a3d 24.14 KiB 1.16 MiB 1.13 MiB
a48979e 24.14 KiB 1.17 MiB 1.15 MiB
151b3ee 24.14 KiB 1.15 MiB 1.13 MiB
36c25b3 24.14 KiB 1.18 MiB 1.16 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant