Fix Cogl namespace (@girs/cogl-2.0 → @girs/cogl-18)#132
Conversation
|
Thanks @AmionSky, agreed that pinning isn't the right long-term fix. One nuance worth flagging: The proper fix is upstream: gjsify/ts-for-gir#432 drops the coupled Plan for this PR: hold it until #432 is published, then swap the exact pins for plain caret ranges. The Cogl namespace fix ( Does that work for you? |
As a suggestion: Just update @girs/cogl-2.0 -> @girs/cogl-18 in this PR , nothing else. |
@girs/cogl-2.0 pulled a second, incompatible copy of the Cogl types into the tree, so a method using both Cairo and Cogl types could not type-check. @girs/cogl-18 is the version @girs/clutter-18 and @girs/meta-18 depend on; switching to it dedupes Cogl and lets Cairo + Cogl be used together. Leaves the @Girs versioning scheme untouched (still on the current rc ranges) so the auto-update workflow in #135 can take over the bumps. Closes #126
c215a46 to
1a0164c
Compare
|
@schnz Good Idea, this PR now does only the Cogl namespace fix 👍 |
Fixes #126 — the Cogl namespace was incorrect.
Cogl namespace incorrect (#126)
@girs/cogl-2.0→@girs/cogl-18.cogl-18is the version@girs/clutter-18and@girs/meta-18depend on; the mismatched2.0namespace pulled a second, incompatible copy of the Cogl types into the tree, so aglobal.d.tsmethod using both Cairo and Cogl types could not type-check. Switching tocogl-18dedupes Cogl and lets Cairo + Cogl be used together.Scope
Per @schnz's suggestion, this PR now does only the Cogl namespace fix — the
@girsversioning scheme is left untouched (still on the current rc ranges). Bumping the@girs/*deps off the release candidates (#125) is left to the auto-update workflow in #135, so it can take over and be exercised end-to-end.Validation
yarn installswapscogl-2.0forcogl-18(resolves to the same rc asclutter-18/meta-18) and touches onlypackage.json+yarn.lock. Full CI sequence green locally:build:types,validate:types,build:example,validate:example,prettier:check.Closes #126