feat(website): custom collapsible JSON viewer with finding path highlighting - #5712
Merged
Conversation
…ighting - Build custom recursive JSON tree renderer (renderCustomJSON) replacing json-formatter-js - Add data-json-path attributes to JSON rows and extract JSON paths from linter findings - Auto-expand parent nodes and highlight matching finding paths on click with smooth scroll - Implement event delegation, safe textContent DOM nodes, and O(1) value-path lookup indexing - Fix copy button component integration and header alignment across detail columns TAG=agy CONV=08e8364f-33ab-44e5-b52f-22b30b10d566
jess-lowe
previously approved these changes
Jul 27, 2026
jess-lowe
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Small nit about catching network/parsing errors, but otherwise I've tested it locally, and it works great too :)
Co-authored-by: Jess Lowe <86962800+jess-lowe@users.noreply.github.com>
Collaborator
Author
Oh cool, thanks for picking that up. I have applied but seems I need your approval again :) |
jess-lowe
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note this was heavily assisted by Antigravity to paper over my failings as a frontend developer.
Right now the code is probably a little more complex than it needs to be, which we can refactor if we provide more specific information where the linting errors are occurring in the file.
You can collapse/expand JSON, there is a JSON copy button now and also you can click on a finding and it will be highlighted in yellow. See attached screenshots.