Refactor empty filter handling in GribSplitterV2#549
Merged
Conversation
mahrsee1997
requested changes
Jun 23, 2026
mahrsee1997
left a comment
mahrsee1997
left a comment
Collaborator
There was a problem hiding this comment.
LGTM!
Please bump version of setup.py and Version.txt.
mahrsee1997
approved these changes
Jul 2, 2026
mahrsee1997
left a comment
mahrsee1997
left a comment
Collaborator
There was a problem hiding this comment.
LGTM!
Just bump the version.txt. Thanks!
j9sh264
force-pushed
the
weather-sp-no-grib-message-match-filter
branch
from
973c59f to
c76524e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(splitter): gracefully handle empty GRIB filter matches
When applying a
--wherefilter expression in GribSplitterV2, files containingzero matching messages previously caused a crash or required a broad try/except
block in the pipeline that swallowed unexpected errors.
This change:
grib_getreturns an empty string (no filter matches).skipped_empty_filterBeam metric for observability.