fix(cargo-workspace): delegate to versioning strategy for cascade bumps in prerelease#2836
Open
anishesg wants to merge 1 commit into
Open
fix(cargo-workspace): delegate to versioning strategy for cascade bumps in prerelease#2836anishesg wants to merge 1 commit into
anishesg wants to merge 1 commit into
Conversation
…ps in prerelease The `CargoWorkspace.bumpVersion()` method was unconditionally using `PatchVersionUpdate().bump()` for cascade-bumped packages, which increments the patch version and carries prerelease suffixes verbatim. This caused packages bumped only as dependencies to get incorrect versions during prerelease windows (e.g., `1.0.0-beta.0` → `1.0.1-beta.0` instead of `1.0.0-beta.1`). Signed-off-by: anish <anishesg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CargoWorkspace.bumpVersion()method was unconditionally usingPatchVersionUpdate().bump()for cascade-bumped packages, which increments the patch version and carries prerelease suffixes verbatim. This caused packages bumped only as dependencies to get incorrect versions during prerelease windows (e.g.,1.0.0-beta.0→1.0.1-beta.0instead of1.0.0-beta.1).This fix ports the solution from the
node-workspaceplugin (PR #2249), which delegates to the configuredversioningStrategywhen available. ThestrategiesByPathmap is already populated inpreconfigure()and is now used inbumpVersion()to apply the correct prerelease strategy to cascade-bumped packages.Added a regression test that verifies prerelease cascade bumps increment the prerelease counter rather than the patch version.
Fixes #2828