Skip to content
This repository was archived by the owner on Jul 16, 2021. It is now read-only.

scipy: Added extra recipe for native package#16

Open
nandra wants to merge 1 commit into
gpanders:masterfrom
nandra:nandra-scipy-master
Open

scipy: Added extra recipe for native package#16
nandra wants to merge 1 commit into
gpanders:masterfrom
nandra:nandra-scipy-master

Conversation

@nandra

@nandra nandra commented Jan 25, 2021

Copy link
Copy Markdown

Signed-off-by: Marek Belisko marek.belisko@gmail.com

Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
@nandra

nandra commented Jan 25, 2021

Copy link
Copy Markdown
Author

Same as #15 just for master

@gpanders gpanders left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having a separate scipy-native recipe, let's just use the BBCLASSEXTENDS mechanism to add the -native variant.

So you'll just add the following to the end of the python3-scipy_1.5.3.bb file:

BBCLASSEXTEND =+ "native"

You actually don't even need to redefine DEPENDS for the native recipe, because Yocto automatically appends -native to all of the values in DEPENDS when building the -native variant.

Other than that, the rest of the recipe looks identical to me.

@nandra

nandra commented Jan 25, 2021

Copy link
Copy Markdown
Author

Original native recipe doesn't build on dunfell. I fails with some strange error which was caused by some cross-compilation flags. I basically extracted it and drop one flag + setup proper DEPENDS native flags.

@gpanders

Copy link
Copy Markdown
Owner

You can use overrides to set variables differently based on whether or not you're building the native package:

DEPENDS_class-native = "..."

FARCH = "${TUNE_CCARGS}"
FARCH_class-native = ""

export FARCH

This is preferable to having two separate recipes. There are plenty of examples of this in the poky repo and in the meta-openembedded layer.

@nandra

nandra commented Jan 26, 2021

Copy link
Copy Markdown
Author

Yes I know. I was in hurry to compile scikit-learn so this was the first shot which works. Thanks for comments I'll give a try what was suggested and post an update. 👍

@nandra

nandra commented Jan 27, 2021

Copy link
Copy Markdown
Author

@gpanders strange it seems that yesterday I have scipy-native somehow cached because today wiped out caches and it's failing. So I suggest to revert #15 or can someone test it pls? If it fails pls revert. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants