Add nightly application validation for top kernels - #518
Merged
Conversation
This was referenced Jul 26, 2026
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||
msaroufim
marked this pull request as ready for review
July 26, 2026 16:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
versionplus a problem-ownedscriptAmerica/Los_Angeleswith an atomic daily claim and at most two Modal jobs concurrentlykernelbot-admin validate-top10Behavior
The candidate query first selects each user's fastest eligible submission, ranks
those per-user winners, and then validates up to 10 distinct users. Validation is
an annotation only: it never removes or reorders leaderboard entries.
The Cholesky workload requires each shape to produce a valid factor, converge in
the mini-training loop, and be at least as fast as the PyTorch baseline.
Implementations may use custom kernels, PyTorch, or a hybrid of both; fallback
is not a validation gate. Kernelboard can render
VALIDATED,X/Y VALIDATED,or
VALIDATION ERROR.Modal already consumes
MODAL_ENVIRONMENT; this PR does not add a secondenvironment setting or custom lookup path.
APPLICATION_VALIDATION_ENABLED=falseis the scheduler kill switch.
Validation
uv run ruff check . --exclude examples/ --line-length 120 --fixPYTEST_MODAL_ENV=pytest uv run pytest tests/ -v— 257 passed, 7 skippedthe
cholesky-validation-debugModal environment, and local Kernelboard API/UIKERNELGUARD_ENABLED, confirming there isno second KernelGuard pass
geomean synchronized-wall speedup
--wait, URL encoding, and requiredadmin authentication
Coordinated rollout
Merge/deploy in this order: