Make application validation manual-only - #523
Open
msaroufim wants to merge 1 commit into
Open
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
APPLICATION_VALIDATION_ENABLEDsetting and scheduler startup hooks--all-users,--only-missing,--wait, and the two-job concurrency boundWhy
Automatic validation would silently expand to every future problem that adds a validation contract, before leaderboard-mode triggering and rate limiting have been designed. Keeping this explicit makes GPU spend and failure handling operator-controlled in the meantime.
Existing validation records and Kernelboard badges are unchanged.
Validation
uv run ruff check . --exclude examples/ --line-length 120uv run pytest -q tests/test_application_validation.py tests/test_admin_api.py tests/test_admin_cli.py tests/test_leaderboard_db.py(120 passed)uv run pytest -q -m 'not integration' tests(252 passed, 14 deselected)