[codex] Merge global content search#628
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the previously merged global content search work onto current
master. PR #602 had been merged into the intermediatecodex/built-in-theme-optionsbranch, but that branch was later closed without merging tomaster, so this brings the feature into the release line.snippet.downloadAllconfig behavior; the old unshippedgist.downloadAllpath remains ignored.formatRelativeTimeutility instead of the stalemomentimport.Validation
npm run test:unit -- tests/utilities/search.test.js tests/utilities/config.test.js tests/utilities/githubApi.test.jsnpm run lintnpm testnpm run test:smokegit diff --checkRendering
npm run test:smokepassed, including the search fixture. The local search fixture screenshot showed the updated search overlay placeholder:Search descriptions, tags, file names, and content....