fix: dynamically check for xprop to prevent crashes on pure Wayland#424
Open
W-Varg wants to merge 1 commit into
Open
fix: dynamically check for xprop to prevent crashes on pure Wayland#424W-Varg wants to merge 1 commit into
W-Varg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a potential crash in GNOME Shell when running on modern, pure Wayland environments (such as Ubuntu 26.04) where X11/Xorg utilities like
xpropare not installed by default.Changes
GLibinwindow.js.xpropis installed on the system usingGLib.find_program_in_path('xprop').xpropis not available, default server-side decoration actions (ServerDecorations) to a safe fallback (ClientDecorations/ styling via GTK CSS injection) instead of executingUtil.spawn(['xprop', ...]), which throws an exception and crashes the extension loop.Why this is needed
In pure Wayland environments without Xorg utilities, attempts to call
xpropfail immediately withGLib.SpawnError(executable not found). This change ensures the extension degrades gracefully and remains fully operational on Wayland.Verification