fix: preserve final response in PassthroughErrorHandler#288
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes lushirong.77 seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
|
This should now be ready for review on my side. The current status check blocker is the HashiCorp CLA gate; I have already signed the CLA before, but the new PR still shows Change summary:
If you want, I can also add a short README/doc note clarifying this default behavior for |
b167ec5 to
4f6af93
Compare
|
Follow-up: I force-pushed the branch so the commit is now authored with my GitHub-linked noreply address ( If the CLA check does not refresh automatically from that updated commit metadata, please let me know and I can re-run whatever recheck flow you prefer. |
|
Quick follow-up on the remaining blocker: the commits on these branches now use my GitHub-linked noreply address, and I've already completed the HashiCorp CLA flow, but If there is a maintainer-side recheck I should trigger, or a preferred support path for a stuck CLA status, I'd appreciate a pointer. Thanks! |
|
Update: I re-ran the HashiCorp CLA flow successfully and the CLA backend now reports my signature as active for this repo/PR context. If the GitHub |
Description
PassthroughErrorHandlerreturn the terminal*http.Responsewithout a competing error when a response existshttp.Client/StandardClient()callers from silently discarding the final HTTP response on retry exhaustionStandardClient/RoundTripperpathRelated Issue
Closes #156
How Has This Been Tested?
PassthroughErrorHandlerStandardClient()preserving the final 500 response