fix: keep response body readable during Backoff#291
Open
happysnaker wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
Client.Dodecides to retry, it currently drains and closesresp.Bodybefore invokingBackoff. That makesBackoffcallbacks unable to inspect retry hints carried in the response body and reproduces thehttp2: response body closedproblem described in #215.This change moves the body drain/close step to after
Backoffreturns, so custom backoff policies can still read the response body during the callback while the connection reuse behavior stays unchanged for the next attempt.It also documents that
resp.Bodyremains readable whileBackoffruns and is drained/closed immediately afterwards when a retry will proceed.Closes #215.
What changed
Backoff(...)beforedrainBody(resp.Body)on retry pathsBackoffBackoffcan read the retry response bodyNotes
Backoffcallback fully consumes the body, the later drain becomes a no-op and still closes it as before