fix: skip retry wait when context deadline is sooner#292
Open
happysnaker wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a retryable request has a context deadline that expires before the next backoff wait finishes, the current implementation still sleeps for that full backoff window and only then returns
context.DeadlineExceededfrom the select onreq.Context().Done().This means callers can spend a long time waiting for a retry that can no longer happen.
This patch checks the computed retry wait against
req.Context().Deadline()and returnscontext.DeadlineExceededimmediately when the next retry window is already impossible.Closes #272.
What changed
timeNow().Add(wait)is later than the request context deadline, abort immediately withcontext.DeadlineExceededNotes