Use parsec parser for project round trip prop tests

[philderbeast]

I've started working on #12138. This changes the property tests for round trip printing and parsing of projects to use the parsec parser from #8889.

Adds parseProjectConfig and exports this from Distribution.Client.ProjectConfig.Parsec. This is used for testing and is the equivalent of:

cabal/cabal-install/src/Distribution/Client/ProjectConfig/Legacy.hs

Lines 1250 to 1252 in 4907eec

	parseLegacyProjectConfig :: FilePath -> BS.ByteString -> ParseResult LegacyProjectConfig
	parseLegacyProjectConfig rootConfig bs =
	parseLegacyProjectConfigFields (ProjectConfigPath $ rootConfig :| []) =<< ParseUtils.readFields bs

The parseProjectConfig function could be defined in the test suite but then we'd have to export fieldsToConfig and readPreprocessFields:

$ git diff
 module Distribution.Client.ProjectConfig.Parsec
   ( -- * Package configuration
     parseProject
-  , parseProjectConfig
   , ProjectConfig (..)
 
     -- ** Parsing
   , ParseResult
   , runParseResult
+  , readPreprocessFields
+  , fieldsToConfig
   ) where

Differences

There are test failures with commas in the packages field:

$ cabal run cabal-install:unit-tests -- -p "round trip packages"
...
Unit Tests
  UnitTests.Distribution.Client.ProjectConfig
    ProjectConfig printing/parsing round trip
      round trip packages: FAIL
        *** Failed! Falsified (after 8 tests and 5 shrinks):
        [PackageLocationString {getPackageLocationString = "Z%{w=g,MZ}"}]
        []
        []
        []
        shown:
        packages: Z%{w=g,MZ}
        
        ProjectConfig {
          projectPackages = [-"Z%{w=g", -"MZ}", +"Z%{w=g,MZ}"],
...
        Use --quickcheck-replay="(SMGen 14836990702317481085 1208827380667102593,7)" to reproduce.

There are test failures with commas in the shared test:

$ cabal run cabal-install:unit-tests -- -p "round trip shared"
...
Unit Tests
  UnitTests.Distribution.Client.ProjectConfig
    ProjectConfig printing/parsing round trip
      round trip shared: FAIL
        *** Failed! Falsified (after 2 tests and 26 shrinks):
        ProjectConfigShared {projectConfigDistDir = Last {getLast = Nothing}, projectConfigConfigFile = Last {getLast = Nothing}, projectConfigProjectDir = Last {getLast = Nothing}, projectConfigProjectFile = Last {getLast = Nothing}, projectConfigProjectFileParser = Last {getLast = Nothing}, projectConfigIgnoreProject = Last {getLast = Nothing}, projectConfigHcFlavor = Last {getLast = Nothing}, projectConfigHcPath = Last {getLast = Nothing}, projectConfigHcPkg = Last {getLast = Nothing}, projectConfigHaddockIndex = Last {getLast = Nothing}, projectConfigInstallDirs = InstallDirs {prefix = Last {getLast = Just "y"}, bindir = Last {getLast = Nothing}, libdir = Last {getLast = Nothing}, libsubdir = Last {getLast = Just "6"}, dynlibdir = Last {getLast = Just "a"}, bytecodelibdir = Last {getLast = Just "G"}, flibdir = Last {getLast = Nothing}, libexecdir = Last {getLast = Just "f"}, libexecsubdir = Last {getLast = Just "/"}, includedir = Last {getLast = Nothing}, datadir = Last {getLast = Just "r"}, datasubdir = Last {getLast = Just "?"}, docdir = Last {getLast = Just ","}, mandir = Last {getLast = Nothing}, htmldir = Last {getLast = Just "1"}, haddockdir = Last {getLast = Nothing}, sysconfdir = Last {getLast = Just "T"}}, projectConfigPackageDBs = [], projectConfigRemoteRepos = [], projectConfigLocalNoIndexRepos = [], projectConfigActiveRepos = Last {getLast = Nothing}, projectConfigIndexState = Last {getLast = Nothing}, projectConfigStoreDir = Last {getLast = Nothing}, projectConfigConstraints = [], projectConfigPreferences = [], projectConfigCabalVersion = Last {getLast = Nothing}, projectConfigSolver = Last {getLast = Nothing}, projectConfigAllowOlder = Nothing, projectConfigAllowNewer = Nothing, projectConfigWriteGhcEnvironmentFilesPolicy = Last {getLast = Nothing}, projectConfigMaxBackjumps = Last {getLast = Nothing}, projectConfigReorderGoals = Last {getLast = Nothing}, projectConfigCountConflicts = Last {getLast = Nothing}, projectConfigFineGrainedConflicts = Last {getLast = Nothing}, projectConfigMinimizeConflictSet = Last {getLast = Nothing}, projectConfigStrongFlags = Last {getLast = Nothing}, projectConfigAllowBootLibInstalls = Last {getLast = Nothing}, projectConfigOnlyConstrained = Last {getLast = Nothing}, projectConfigPerComponent = Last {getLast = Nothing}, projectConfigIndependentGoals = Last {getLast = Nothing}, projectConfigPreferOldest = Last {getLast = Nothing}, projectConfigProgPathExtra = [], projectConfigMultiRepl = Last {getLast = Nothing}}
        shown:
        prefix: y
        libsubdir: 6
        dynlibdir: a
        bytecodelibdir: G
        libexecdir: f
        libexecsubdir: /
        datadir: r
        datasubdir: ?
        docdir: ,
        htmldir: 1
        sysconfdir: T
        
        ERROR: (Nothing,PErrorWithSource {perrorSource = PUnknownSource, perror = PError {perrorPosition = Position 9 9, perrorMessage = "\nunexpected ','\nexpecting white space, string, identifier or end of input\n"}} :| [])
        Use --quickcheck-replay="(SMGen 4102444156980047325 2848404851119429861,1)" to reproduce.

There's a test failure in the local test parsing the debug level:

$ cabal run cabal-install:unit-tests -- -p "round trip local"
...
Unit Tests
  UnitTests.Distribution.Client.ProjectConfig
    ProjectConfig printing/parsing round trip
      round trip local: FAIL (0.01s)
        *** Failed! Exception: 'Can't parse debug info level False' (after 2 tests and 41 shrinks):
        PackageConfig {packageConfigProgramPaths = MapLast {getMapLast = fromList []}, packageConfigProgramArgs = MapMappend {getMapMappend = fromList []}, packageConfigProgramPathExtra = [], packageConfigFlagAssignment = fromList [], packageConfigVanillaLib = Last {getLast = Nothing}, packageConfigSharedLib = Last {getLast = Nothing}, packageConfigStaticLib = Last {getLast = Nothing}, packageConfigBytecodeLib = Last {getLast = Nothing}, packageConfigDynExe = Last {getLast = Nothing}, packageConfigFullyStaticExe = Last {getLast = Nothing}, packageConfigProf = Last {getLast = Nothing}, packageConfigProfLib = Last {getLast = Nothing}, packageConfigProfShared = Last {getLast = Nothing}, packageConfigProfExe = Last {getLast = Nothing}, packageConfigProfDetail = Last {getLast = Nothing}, packageConfigProfLibDetail = Last {getLast = Nothing}, packageConfigConfigureArgs = [], packageConfigOptimization = Last {getLast = Nothing}, packageConfigProgPrefix = Last {getLast = Nothing}, packageConfigProgSuffix = Last {getLast = Nothing}, packageConfigExtraLibDirs = [], packageConfigExtraLibDirsStatic = [], packageConfigExtraFrameworkDirs = [], packageConfigExtraIncludeDirs = [], packageConfigGHCiLib = Last {getLast = Nothing}, packageConfigSplitSections = Last {getLast = Nothing}, packageConfigSplitObjs = Last {getLast = Nothing}, packageConfigStripExes = Last {getLast = Nothing}, packageConfigStripLibs = Last {getLast = Nothing}, packageConfigTests = Last {getLast = Nothing}, packageConfigBenchmarks = Last {getLast = Nothing}, packageConfigCoverage = Last {getLast = Nothing}, packageConfigRelocatable = Last {getLast = Nothing}, packageConfigDebugInfo = Last {getLast = Just NoDebugInfo}, packageConfigDumpBuildInfo = Last {getLast = Nothing}, packageConfigRunTests = Last {getLast = Nothing}, packageConfigDocumentation = Last {getLast = Nothing}, packageConfigHaddockHoogle = Last {getLast = Nothing}, packageConfigHaddockHtml = Last {getLast = Nothing}, packageConfigHaddockHtmlLocation = Last {getLast = Nothing}, packageConfigHaddockForeignLibs = Last {getLast = Nothing}, packageConfigHaddockExecutables = Last {getLast = Nothing}, packageConfigHaddockTestSuites = Last {getLast = Nothing}, packageConfigHaddockBenchmarks = Last {getLast = Nothing}, packageConfigHaddockInternal = Last {getLast = Nothing}, packageConfigHaddockCss = Last {getLast = Nothing}, packageConfigHaddockLinkedSource = Last {getLast = Nothing}, packageConfigHaddockQuickJump = Last {getLast = Nothing}, packageConfigHaddockHscolourCss = Last {getLast = Nothing}, packageConfigHaddockContents = Last {getLast = Nothing}, packageConfigHaddockIndex = Last {getLast = Nothing}, packageConfigHaddockBaseUrl = Last {getLast = Nothing}, packageConfigHaddockResourcesDir = Last {getLast = Nothing}, packageConfigHaddockOutputDir = Last {getLast = Nothing}, packageConfigHaddockUseUnicode = Last {getLast = Nothing}, packageConfigHaddockForHackage = Last {getLast = Nothing}, packageConfigTestHumanLog = Last {getLast = Nothing}, packageConfigTestMachineLog = Last {getLast = Nothing}, packageConfigTestShowDetails = Last {getLast = Nothing}, packageConfigTestKeepTix = Last {getLast = Nothing}, packageConfigTestWrapper = Last {getLast = Nothing}, packageConfigTestFailWhenNoTestSuites = Last {getLast = Nothing}, packageConfigTestTestOptions = [], packageConfigBenchmarkOptions = []}
        shown:
        debug-info: False
        
        Exception thrown while showing test case: 'Can't parse debug info level False'
        Use --quickcheck-replay="(SMGen 3113468884534292331 13010642303015172695,1)" to reproduce.

There's a test failure in the specific test parsing the debug level (same goes for the all test):

$ cabal run cabal-install:unit-tests -- -p "round trip specific"
Warning: this is a debug build of cabal-install with assertions enabled.
Unit Tests
  UnitTests.Distribution.Client.ProjectConfig
    ProjectConfig printing/parsing round trip
      round trip specific: FAIL (0.02s)
        *** Failed! Exception: 'Can't parse debug info level False' (after 3 tests and 43 shrinks):
        fromList [(PackageName "I",NonMEmpty {getNonMEmpty = PackageConfig {packageConfigProgramPaths = MapLast {getMapLast = fromList []}, packageConfigProgramArgs = MapMappend {getMapMappend = fromList []}, packageConfigProgramPathExtra = [], packageConfigFlagAssignment = fromList [], packageConfigVanillaLib = Last {getLast = Nothing}, packageConfigSharedLib = Last {getLast = Nothing}, packageConfigStaticLib = Last {getLast = Nothing}, packageConfigBytecodeLib = Last {getLast = Nothing}, packageConfigDynExe = Last {getLast = Nothing}, packageConfigFullyStaticExe = Last {getLast = Nothing}, packageConfigProf = Last {getLast = Nothing}, packageConfigProfLib = Last {getLast = Nothing}, packageConfigProfShared = Last {getLast = Nothing}, packageConfigProfExe = Last {getLast = Nothing}, packageConfigProfDetail = Last {getLast = Nothing}, packageConfigProfLibDetail = Last {getLast = Nothing}, packageConfigConfigureArgs = [], packageConfigOptimization = Last {getLast = Nothing}, packageConfigProgPrefix = Last {getLast = Nothing}, packageConfigProgSuffix = Last {getLast = Nothing}, packageConfigExtraLibDirs = [], packageConfigExtraLibDirsStatic = [], packageConfigExtraFrameworkDirs = [], packageConfigExtraIncludeDirs = [], packageConfigGHCiLib = Last {getLast = Nothing}, packageConfigSplitSections = Last {getLast = Nothing}, packageConfigSplitObjs = Last {getLast = Nothing}, packageConfigStripExes = Last {getLast = Nothing}, packageConfigStripLibs = Last {getLast = Nothing}, packageConfigTests = Last {getLast = Nothing}, packageConfigBenchmarks = Last {getLast = Nothing}, packageConfigCoverage = Last {getLast = Nothing}, packageConfigRelocatable = Last {getLast = Nothing}, packageConfigDebugInfo = Last {getLast = Just NoDebugInfo}, packageConfigDumpBuildInfo = Last {getLast = Nothing}, packageConfigRunTests = Last {getLast = Nothing}, packageConfigDocumentation = Last {getLast = Nothing}, packageConfigHaddockHoogle = Last {getLast = Nothing}, packageConfigHaddockHtml = Last {getLast = Nothing}, packageConfigHaddockHtmlLocation = Last {getLast = Nothing}, packageConfigHaddockForeignLibs = Last {getLast = Nothing}, packageConfigHaddockExecutables = Last {getLast = Nothing}, packageConfigHaddockTestSuites = Last {getLast = Nothing}, packageConfigHaddockBenchmarks = Last {getLast = Nothing}, packageConfigHaddockInternal = Last {getLast = Nothing}, packageConfigHaddockCss = Last {getLast = Nothing}, packageConfigHaddockLinkedSource = Last {getLast = Nothing}, packageConfigHaddockQuickJump = Last {getLast = Nothing}, packageConfigHaddockHscolourCss = Last {getLast = Nothing}, packageConfigHaddockContents = Last {getLast = Nothing}, packageConfigHaddockIndex = Last {getLast = Nothing}, packageConfigHaddockBaseUrl = Last {getLast = Nothing}, packageConfigHaddockResourcesDir = Last {getLast = Nothing}, packageConfigHaddockOutputDir = Last {getLast = Nothing}, packageConfigHaddockUseUnicode = Last {getLast = Nothing}, packageConfigHaddockForHackage = Last {getLast = Nothing}, packageConfigTestHumanLog = Last {getLast = Nothing}, packageConfigTestMachineLog = Last {getLast = Nothing}, packageConfigTestShowDetails = Last {getLast = Nothing}, packageConfigTestKeepTix = Last {getLast = Nothing}, packageConfigTestWrapper = Last {getLast = Nothing}, packageConfigTestFailWhenNoTestSuites = Last {getLast = Nothing}, packageConfigTestTestOptions = [], packageConfigBenchmarkOptions = []}})]
        shown:
        
        package I
          debug-info: False
        
        Exception thrown while showing test case: 'Can't parse debug info level False'
        Use --quickcheck-replay="(SMGen 18355447672091957642 9032507782252479951,2)" to reproduce.

---

• Patches conform to the coding conventions.
• Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).