Crash fixes, performance improvements and some code refactoring#4
Open
randompooper wants to merge 3 commits into
Open
Crash fixes, performance improvements and some code refactoring#4randompooper wants to merge 3 commits into
randompooper wants to merge 3 commits into
Conversation
Example of invalid timestamp produced: 00:02:60.354 Here can't be more than 60 seconds
- Use fast (inexact) seek to process videos faster - Parallelize clip creation for a faster pooping process - Possibly fix issues with ffmpeg failing (file name issues, unquoting, quoting where necessary, etc) - Fix incompatibility with Linux systems (removed quotes where unnecessary) - Allow all media formats supported by ffmpeg (it is still converted to mp4 though) - Halved chance of squidward effect being applied - Mostly minor refactoring around the code (add pseudorandom prefixes to temporary files, reduce concatenation frequency, etc)
- construct command lines using arrays instead of string concatenation to support file names with white spaces and quotes - move ffmpeg and magick execution to Utilities - remove unused getVideoLength function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appropriate PR will be made to YTPPlusUI