ci: upgrade done gate to self-check + 1-line aggregation#51
Merged
Conversation
Pattern source: helly25/bzl. Two parts: 1. Self-check: parses the workflow with yq, fails if any declared job (other than done itself) is absent from done.needs. A newly added job that someone forgets to wire in fails CI loudly. 2. Failure aggregation: single-line contains(needs.*.result, ...) guard. GitHub's Actions UI already shows per-job results. Part of a batch syncing the gate across helly25/* repos.
This was referenced Jun 13, 2026
beautysh v6.2.1 imports pkg_resources from setuptools. setuptools >= 80 (released 2025) dropped that shim, so the hook fails on fresh CI runners with ModuleNotFoundError. bzl already has the fix: bump to v6.4.3 + add additional_dependencies: [setuptools]. Copying that pattern verbatim.
Fab-Cat
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pattern source: helly25/bzl. Two parts:
yq, fails if any declared job (other thandoneitself) is absent fromdone.needs. A newly added job that someone forgets to wire in fails CI loudly.contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')guard. GitHub's Actions UI already shows per-job results.Part of a batch syncing the gate across helly25/* repos (helly25/coderef#33, helly25/mbo#189, helly25/bashtest#15).