Improve conventionnal commits#5
Merged
Merged
Conversation
- introduce vscode-settings input for custom settings path - implement auto-detection of scopes from settings.json Co-authored-by: Copilot <copilot@github.com>
✅ PR Validation Passed
📋 Pipeline Status
🤖 Generated by @helpers4 CI • 2026-05-04 |
There was a problem hiding this comment.
Pull request overview
This PR enhances the conventional-commits GitHub Action by allowing it to auto-load the allowed scope list from a VS Code settings.json file, reducing duplication between editor configuration and CI.
Changes:
- Add a new
vscode-settingsinput and wire it through to the validation script. - Update the validation script to auto-detect
conventionalCommits.scopeswhenscopesinput is empty. - Update documentation and the repo PR validation workflow to rely on VS Code settings for scopes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
conventional-commits/scripts/validate.sh |
Adds auto-detection of scopes via jq from a configurable VS Code settings path. |
conventional-commits/action.yml |
Introduces the vscode-settings input and passes it to the script via env. |
conventional-commits/README.md |
Documents the new input and adds usage examples for auto-reading scopes. |
.github/workflows/pr-validation.yml |
Removes hard-coded scopes to rely on auto-detection from .vscode/settings.json. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
19
to
22
| uses: helpers4/action/conventional-commits@main | ||
| with: | ||
| checkout: "true" | ||
| scopes: "conventional-commits|deps|CI-CD" | ||
| pr-comment: "error" |
…with comments support
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of what this PR does and why it's needed.
Type of Change
Related Issues
Closes #(issue number)
How Has This Been Tested?
Describe the tests you ran and how to reproduce them:
Checklist
Screenshots (if applicable)
Add screenshots for UI changes.
Additional Context
Add any other context about the PR here.