Skip to content

Packit: Use directly version number (default)#19

Merged
Growl1234 merged 1 commit into
hfp:mainfrom
Growl1234:main
Jun 25, 2026
Merged

Packit: Use directly version number (default)#19
Growl1234 merged 1 commit into
hfp:mainfrom
Growl1234:main

Conversation

@Growl1234

Copy link
Copy Markdown
Collaborator

No description provided.

@Growl1234 Growl1234 merged commit 5fd0080 into hfp:main Jun 25, 2026
15 checks passed
@hfp

hfp commented Jun 25, 2026

Copy link
Copy Markdown
Owner

I moved/updated the tag and updated the release.

hfp added a commit to hfp/libxstream that referenced this pull request Jun 25, 2026
@Growl1234

Copy link
Copy Markdown
Collaborator Author

One another problem detected: make will directly take version from git tag, but the package exported does not contain .git directory, so it returns with still 0.0.0; what's worse is that it will cover the version already set in CMakeLists.txt. I'll fix it soon.

@Growl1234

Copy link
Copy Markdown
Collaborator Author

One another problem detected: make will directly take version from git tag, but the package exported does not contain .git directory, so it returns with still 0.0.0; what's worse is that it will cover the version already set in CMakeLists.txt. I'll fix it soon.

Fixed by #20; tag is updated.

Currently there should not be other issues affecting a normal release artifact, so I uploaded a dedicated tarball to the release page. The tag better not update in the future to prevent unintented issue for downstream.

@hfp

hfp commented Jun 26, 2026

Copy link
Copy Markdown
Owner

Shall I re-release version 1.0 wrt #20 ?

@Growl1234

Copy link
Copy Markdown
Collaborator Author

Shall I re-release version 1.0 wrt #20 ?

I've updated the tag after merging #20; commit 2132ebb is included in this tag, so nothing needed for now.

@hfp

hfp commented Jun 26, 2026

Copy link
Copy Markdown
Owner

Shall I re-release version 1.0 wrt #20 ?

I've updated the tag after merging #20; commit 2132ebb is included in this tag, so nothing needed for now.

Excellent, you moved the tag and rereleased; perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants