#SJP
TBA
TBA
- Awareness: I have read the acceptance criteria
- JIRA Backlog: The JIRA ID has been referenced
- Validation: There is a unit test that verifies the solution
- Validation: The defined architecture has been applied (eg CQRS, DDD, LLD, etc)
- Validation: The code is easy to understand and maintain
- Validation: Security has been considered and documented
- Validation: The code is scalable enough to support a huge number of events
- Validation: The performance is acceptable with huge data (eg not excessive serialisation, small synchronised sections, unnecessary object creation, etc)
- Validation: There are no undiscussed TODO or WIP comments
- Validation: There are no formatting issues (eg checkstyle, name conventions)
- Validation: The code follows SOLID principles
- Validation: There is sufficient documentation (eg public methods, README, etc)
- Validation: Exceptions have been used and handled correctly (no result codes)
- Validation: Logging sufficient and not excessive
- Validation: Resources are released (eg streams, database connections, etc)
- Validation: Sensitive data has been protected/purged (eg from logs, exceptions, etc)
- Validation: Inputs are validated
- Testing: Sensible unit tests been written to test each behaviour described by the AC
- Validation: Have all Sonar issues been fixed?
- Validation: Have you marked classes as final if not being used for inheritance?
- Validation: Are prepared SQL statements used?
- Validation: All potentially reusable components have been abstracted to shared modules
- Testing: No irrelevant snapshots have been updated
Pull requests are welcome. For major changes, please open an issue first to discuss what you would like to change.
Please make sure to update tests as appropriate.
TBA