Improve CarPlay settings selection avoiding screen blinks#4820
Draft
bgoncal wants to merge 1 commit into
Draft
Conversation
Contributor
|
Found 21 unused localization strings in the codebase. Click to see detailsTo clean up these strings, manually remove them from the |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CarPlay Settings selection flows (main server and quick access layout) to avoid UI “blinks” by deferring persistence until the user leaves the selection list, while keeping the selected checkmark updated in-place.
Changes:
- Introduces pending selection state in
CarPlayServerListViewModelfor server and layout choices, committed when the selection template disappears. - Updates
CarPlayServersListTemplateselection templates to refresh sections in-place (checkmark updates) instead of immediately popping the template. - Commits pending selections in
templateWillDisappearfor server/layout selection templates.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Sources/CarPlay/Templates/Servers/CarPlayServerListViewModel.swift | Adds pending server/layout selection state and commit logic to defer persistence and reduce UI blinking. |
| Sources/CarPlay/Templates/Servers/CarPlayServerListTemplate.swift | Updates CarPlay selection templates to update checkmarks via updateSections and commit on template disappearance. |
Comment on lines
+142
to
+145
| guard pendingLayout != quickAccessLayout else { | ||
| return | ||
| } | ||
|
|
Comment on lines
+41
to
+52
| func commitServerSelection() { | ||
| guard let pendingServer else { | ||
| return | ||
| } | ||
| self.pendingServer = nil | ||
|
|
||
| guard pendingServer.identifier != CarPlayPreferredServer.current?.identifier else { | ||
| return | ||
| } | ||
|
|
||
| setServer(server: pendingServer) | ||
| } |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4820 +/- ##
=======================================
Coverage ? 45.02%
=======================================
Files ? 278
Lines ? 16996
Branches ? 0
=======================================
Hits ? 7652
Misses ? 9344
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes