security: use environment variable substitution for db credentials#802
Merged
yeasy merged 3 commits intoJun 30, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the dev Docker Compose configuration to allow overriding database passwords via an environment variable instead of hardcoding them.
Changes:
- Parameterized
POSTGRES_PASSWORDand appDB_PASSWORDusing${DB_PASSWORD:-123456}.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - POSTGRES_DB=api_engine | ||
| - POSTGRES_USER=postgres | ||
| - POSTGRES_PASSWORD=123456 | ||
| - POSTGRES_PASSWORD=${DB_PASSWORD:-123456} |
| - DB_NAME=api_engine | ||
| - DB_USER=postgres | ||
| - DB_PASSWORD=123456 | ||
| - DB_PASSWORD=${DB_PASSWORD:-123456} |
| - POSTGRES_DB=api_engine | ||
| - POSTGRES_USER=postgres | ||
| - POSTGRES_PASSWORD=123456 | ||
| - POSTGRES_PASSWORD=${DB_PASSWORD:-123456} |
Signed-off-by: saiashok103 <saiashok103@gmail.com>
Contributor
|
The commit needs a sign-off per policy required. |
saiashok0981
force-pushed
the
fix/docker-compose-hardcoded-db-credentials
branch
from
a6ccb08 to
569d974
Compare
yeasy
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.