Skip to content

Fix deprecated property writes with symfony/http-foundation 8.1 #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
binaryfire merged 7 commits into from
Jul 6, 2026
Merged

Fix deprecated property writes with symfony/http-foundation 8.1 #417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f02e829
Fix deprecated property writes with symfony/http-foundation 8.1
anabeto93 Jul 6, 2026
50fb34e
Merge remote-tracking branch 'origin/0.4' into fix/symfony-http-found…
binaryfire Jul 6, 2026
a68759e
Pass empty string to the parent Response constructor
anabeto93 Jul 6, 2026
e9409b3
Merge remote-tracking branch 'refs/remotes/pr/417' into fix/symfony-h…
binaryfire Jul 6, 2026
b3ff72b
Port Laravel JSON request tests
binaryfire Jul 6, 2026
ae3f8fd
Cover HTTP response construction
binaryfire Jul 6, 2026
38b6682
Raise Symfony component floor to 8.1
binaryfire Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions _archive/src/filesystem/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@
"require": {
"php": "^8.4",
"psr/http-message": "^2.0",
"symfony/finder": "^8.0",
"symfony/http-foundation": "^8.0",
"symfony/http-kernel": "^8.0",
"symfony/finder": "^8.1",
"symfony/http-foundation": "^8.1",
"symfony/http-kernel": "^8.1",
"hypervel/collections": "^0.4",
"hypervel/conditionable": "^0.4",
"hypervel/container": "^0.4",
Expand All @@ -58,7 +58,7 @@
"league/flysystem-google-cloud-storage": "Required to use the Flysystem Google Cloud Storage driver (^3.25.1).",
"league/flysystem-ftp": "Required to use the Flysystem FTP driver (^3.25.1).",
"league/flysystem-sftp-v3": "Required to use the Flysystem SFTP driver (^3.25.1).",
"symfony/filesystem": "Required to use relative symbolic links (^8.0)."
"symfony/filesystem": "Required to use relative symbolic links (^8.1)."
},
"config": {
"sort-packages": true
Expand Down
4 changes: 2 additions & 2 deletions _archive/src/serializer/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
"php": "^8.4",
"doctrine/instantiator": "^1.5|^2.0",
"hypervel/contracts": "^0.4",
"symfony/property-access": "^8.0",
"symfony/serializer": "^8.0"
"symfony/property-access": "^8.1",
"symfony/serializer": "^8.1"
},
"config": {
"sort-packages": true
Expand Down
36 changes: 18 additions & 18 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,22 +183,22 @@
"psy/psysh": "^0.12.22",
"sentry/sentry": "^4.15",
"spomky-labs/otphp": "^11.0",
"symfony/console": "^8.0",
"symfony/error-handler": "^8.0",
"symfony/finder": "^8.0",
"symfony/http-foundation": "^8.0",
"symfony/http-kernel": "^8.0.12",
"symfony/mailer": "^8.0.12",
"symfony/mime": "^8.0.12",
"symfony/console": "^8.1",
"symfony/error-handler": "^8.1",
"symfony/finder": "^8.1",
"symfony/http-foundation": "^8.1",
"symfony/http-kernel": "^8.1",
"symfony/mailer": "^8.1",
"symfony/mime": "^8.1",
"symfony/polyfill-php85": "^1.33",
"symfony/polyfill-php86": "^1.36",
"symfony/process": "^8.0.5",
"symfony/property-access": "^8.0",
"symfony/psr-http-message-bridge": "^8.0",
"symfony/routing": "^8.0.12",
"symfony/process": "^8.1",
"symfony/property-access": "^8.1",
"symfony/psr-http-message-bridge": "^8.1",
"symfony/routing": "^8.1",
"symfony/serializer": "^8.1",
"symfony/uid": "^8.0",
"symfony/var-dumper": "^8.0",
"symfony/uid": "^8.1",
"symfony/var-dumper": "^8.1",
"tijsverkoyen/css-to-inline-styles": "^2.2.5",
"vlucas/phpdotenv": "^5.6.1",
"voku/portable-ascii": "^2.0.2",
Expand Down Expand Up @@ -295,11 +295,11 @@
"pusher/pusher-php-server": "^7.2",
"resend/resend-php": "^1.0",
"swoole/ide-helper": "^6.0.2",
"symfony/filesystem": "^8.0",
"symfony/http-client": "^8.0",
"symfony/mailgun-mailer": "^8.0",
"symfony/postmark-mailer": "^8.0",
"symfony/yaml": "^8.0.12",
"symfony/filesystem": "^8.1",
"symfony/http-client": "^8.1",
"symfony/mailgun-mailer": "^8.1",
"symfony/postmark-mailer": "^8.1",
"symfony/yaml": "^8.1",
"typesense/typesense-php": "^5.2"
},
"config": {
Expand Down
2 changes: 1 addition & 1 deletion dogfood/testbench-package/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"hypervel/testbench": "0.4.x-dev",
"mockery/mockery": "1.6.x-dev",
"phpunit/phpunit": "^13.0.3",
"symfony/yaml": "^8.0.12"
"symfony/yaml": "^8.1"
},
"extra": {
"hypervel": {
Expand Down
2 changes: 1 addition & 1 deletion src/console/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"php": "^8.4",
"dragonmantank/cron-expression": "^3.4",
"guzzlehttp/guzzle": "^7.8.2",
"symfony/console": "^8.0",
"symfony/console": "^8.1",
"hypervel/bus": "^0.4",
"hypervel/cache": "^0.4",
"hypervel/collections": "^0.4",
Expand Down
2 changes: 1 addition & 1 deletion src/context/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
],
"require": {
"php": "^8.4",
"symfony/http-foundation": "^8.0",
"symfony/http-foundation": "^8.1",
"hypervel/coroutine": "^0.4",
"hypervel/engine": "^0.4",
"hypervel/http": "^0.4",
Expand Down
2 changes: 1 addition & 1 deletion src/core/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"hypervel/coordinator": "^0.4",
"hypervel/coroutine": "^0.4",
"psr/log": "^3.0",
"symfony/console": "^8.0"
"symfony/console": "^8.1"
},
"config": {
"sort-packages": true
Expand Down
4 changes: 2 additions & 2 deletions src/database/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@
"php": "^8.4",
"brick/math": "^0.16",
"nesbot/carbon": "^3.8.4",
"symfony/console": "^8.0",
"symfony/console": "^8.1",
"symfony/polyfill-php86": "^1.36",
"symfony/process": "^8.0.5",
"symfony/process": "^8.1",
"hypervel/broadcasting": "^0.4",
"hypervel/collections": "^0.4",
"hypervel/conditionable": "^0.4",
Expand Down
10 changes: 5 additions & 5 deletions src/filesystem/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@
"league/flysystem-path-prefixing": "^3.25.1",
"league/flysystem-read-only": "^3.25.1",
"psr/http-message": "^2.0",
"symfony/finder": "^8.0",
"symfony/http-foundation": "^8.0",
"symfony/http-kernel": "^8.0.12",
"symfony/finder": "^8.1",
"symfony/http-foundation": "^8.1",
"symfony/http-kernel": "^8.1",
"hypervel/collections": "^0.4",
"hypervel/conditionable": "^0.4",
"hypervel/container": "^0.4",
Expand All @@ -59,8 +59,8 @@
"league/flysystem-ftp": "Required to use the Flysystem FTP driver (^3.25.1).",
"league/flysystem-google-cloud-storage": "Required to use the Flysystem Google Cloud Storage driver (^3.25.1).",
"league/flysystem-sftp-v3": "Required to use the Flysystem SFTP driver (^3.25.1).",
"symfony/filesystem": "Required to use relative symbolic links (^8.0).",
"symfony/mime": "Required to enable support for guessing extensions (^8.0)."
"symfony/filesystem": "Required to use relative symbolic links (^8.1).",
"symfony/mime": "Required to enable support for guessing extensions (^8.1)."
},
"config": {
"sort-packages": true
Expand Down
2 changes: 1 addition & 1 deletion src/fortify/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"hypervel/view": "^0.4",
"psr/clock": "^1.0",
"spomky-labs/otphp": "^11.0",
"symfony/console": "^8.0"
"symfony/console": "^8.1"
},
"autoload": {
"psr-4": {
Expand Down
12 changes: 6 additions & 6 deletions src/foundation/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@
"laravel/serializable-closure": "^2.0.10",
"nesbot/carbon": "^3.8.4",
"psr/clock": "^1.0",
"symfony/console": "^8.0",
"symfony/error-handler": "^8.0",
"symfony/finder": "^8.0",
"symfony/http-foundation": "^8.0",
"symfony/http-kernel": "^8.0.12",
"symfony/var-dumper": "^8.0",
"symfony/console": "^8.1",
"symfony/error-handler": "^8.1",
"symfony/finder": "^8.1",
"symfony/http-foundation": "^8.1",
"symfony/http-kernel": "^8.1",
"symfony/var-dumper": "^8.1",
"vlucas/phpdotenv": "^5.6.1",
"hypervel/auth": "^0.4",
"hypervel/broadcasting": "^0.4",
Expand Down
2 changes: 1 addition & 1 deletion src/horizon/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"hypervel/redis": "^0.4",
"hypervel/support": "^0.4",
"hypervel/watcher": "^0.4",
"symfony/process": "^8.0"
"symfony/process": "^8.1"
},
"autoload": {
"psr-4": {
Expand Down
2 changes: 1 addition & 1 deletion src/http-server/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"hypervel/engine": "^0.4",
"hypervel/http": "^0.4",
"hypervel/server": "^0.4",
"symfony/http-foundation": "^8.0"
"symfony/http-foundation": "^8.1"
},
"config": {
"sort-packages": true
Expand Down
6 changes: 3 additions & 3 deletions src/http/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@
"guzzlehttp/guzzle": "^7.8.2",
"guzzlehttp/uri-template": "^1.0",
"nesbot/carbon": "^3.8.4",
"symfony/http-foundation": "^8.0",
"symfony/http-kernel": "^8.0.12",
"symfony/mime": "^8.0.12",
"symfony/http-foundation": "^8.1",
"symfony/http-kernel": "^8.1",
"symfony/mime": "^8.1",
"hypervel/collections": "^0.4",
"hypervel/conditionable": "^0.4",
"hypervel/container": "^0.4",
Expand Down
6 changes: 5 additions & 1 deletion src/http/src/Request.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,11 @@ public static function createFromBase(SymfonyRequest $request): static
$newRequest->content = $request->content;

if ($newRequest->isJson()) {
$newRequest->request = $newRequest->json();
// Fill the request bag with the JSON payload and share the same bag
// as the JSON cache, mirroring the aliasing of a direct assignment
// without hitting Symfony 8.1's deprecated property setter.
$newRequest->request->replace($newRequest->json()->all());
$newRequest->setJson($newRequest->request);
}

if ($request instanceof self) {
Expand Down
7 changes: 3 additions & 4 deletions src/http/src/Response.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
use Override;
use RuntimeException;
use Symfony\Component\HttpFoundation\Response as SymfonyResponse;
use Symfony\Component\HttpFoundation\ResponseHeaderBag;

class Response extends SymfonyResponse
{
Expand Down Expand Up @@ -49,11 +48,11 @@ class Response extends SymfonyResponse
*/
public function __construct(mixed $content = '', int $status = 200, array $headers = [])
{
$this->headers = new ResponseHeaderBag($headers);
// The parent constructor accepts the headers since Symfony 8.1; assigning
// the property directly would hit the deprecated property setter.
parent::__construct('', $status, $headers);

$this->setContent($content);
$this->setStatusCode($status);
$this->setProtocolVersion('1.0');
}

/**
Expand Down
4 changes: 2 additions & 2 deletions src/inertia/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@
"hypervel/support": "^0.4",
"hypervel/testing": "^0.4",
"hypervel/view": "^0.4",
"symfony/console": "^8.0",
"symfony/process": "^8.0"
"symfony/console": "^8.1",
"symfony/process": "^8.1"
},
"config": {
"sort-packages": true
Expand Down
8 changes: 4 additions & 4 deletions src/mail/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"php": "^8.4",
"league/commonmark": "^2.7",
"psr/log": "^3.0",
"symfony/mailer": "^8.0.12",
"symfony/mailer": "^8.1",
"tijsverkoyen/css-to-inline-styles": "^2.2.5",
"hypervel/bus": "^0.4",
"hypervel/collections": "^0.4",
Expand Down Expand Up @@ -64,9 +64,9 @@
},
"suggest": {
"aws/aws-sdk-php": "Required to use the SES mail driver (^3.235.5).",
"symfony/http-client": "Required to use the Symfony API mail transports (^8.0).",
"symfony/mailgun-mailer": "Required to enable support for the Mailgun mail transport (^8.0).",
"symfony/postmark-mailer": "Required to enable support for the Postmark mail transport (^8.0).",
"symfony/http-client": "Required to use the Symfony API mail transports (^8.1).",
"symfony/mailgun-mailer": "Required to enable support for the Mailgun mail transport (^8.1).",
"symfony/postmark-mailer": "Required to enable support for the Postmark mail transport (^8.1).",
"resend/resend-php": "Required to enable support for the Resend mail transport (^1.0)."
}
}
2 changes: 1 addition & 1 deletion src/notifications/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"php": "^8.4",
"guzzlehttp/guzzle": "^7.8.2",
"psr/http-message": "^2.0",
"symfony/mailer": "^8.0.12",
"symfony/mailer": "^8.1",
"hypervel/broadcasting": "^0.4",
"hypervel/bus": "^0.4",
"hypervel/collections": "^0.4",
Expand Down
2 changes: 1 addition & 1 deletion src/passkeys/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"hypervel/support": "^0.4",
"hypervel/validation": "^0.4",
"paragonie/constant_time_encoding": "^3.1",
"symfony/console": "^8.0",
"symfony/console": "^8.1",
"symfony/serializer": "^8.1",
"web-auth/cose-lib": "^4.5",
"web-auth/webauthn-lib": "^5.3"
Expand Down
2 changes: 1 addition & 1 deletion src/process/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"hypervel/contracts": "^0.4",
"hypervel/macroable": "^0.4",
"hypervel/support": "^0.4",
"symfony/process": "^8.0.5"
"symfony/process": "^8.1"
},
"autoload": {
"psr-4": {
Expand Down
4 changes: 2 additions & 2 deletions src/prompts/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
"ext-mbstring": "*",
"composer-runtime-api": "^2.2",
"nunomaduro/termwind": "^2.0",
"symfony/console": "^8.0",
"symfony/process": "^8.0",
"symfony/console": "^8.1",
"symfony/process": "^8.1",
"hypervel/collections": "^0.4",
"hypervel/context": "^0.4",
"hypervel/coroutine": "^0.4"
Expand Down
4 changes: 2 additions & 2 deletions src/queue/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
"php": "^8.4",
"laravel/serializable-closure": "^2.0.10",
"nesbot/carbon": "^3.8.4",
"symfony/console": "^8.0",
"symfony/process": "^8.0.5",
"symfony/console": "^8.1",
"symfony/process": "^8.1",
"hypervel/bus": "^0.4",
"hypervel/cache": "^0.4",
"hypervel/collections": "^0.4",
Expand Down
10 changes: 5 additions & 5 deletions src/routing/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@
"hypervel/session": "^0.4",
"hypervel/support": "^0.4",
"hypervel/view": "^0.4",
"symfony/console": "^8.0",
"symfony/http-foundation": "^8.0",
"symfony/http-kernel": "^8.0.12",
"symfony/psr-http-message-bridge": "^8.0",
"symfony/routing": "^8.0.12"
"symfony/console": "^8.1",
"symfony/http-foundation": "^8.1",
"symfony/http-kernel": "^8.1",
"symfony/psr-http-message-bridge": "^8.1",
"symfony/routing": "^8.1"
},
"config": {
"sort-packages": true
Expand Down
2 changes: 1 addition & 1 deletion src/scout/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"hypervel/pagination": "^0.4",
"hypervel/queue": "^0.4",
"hypervel/support": "^0.4",
"symfony/console": "^8.0"
"symfony/console": "^8.1"
},
"suggest": {
"algolia/algoliasearch-client-php": "Required for Algolia driver (^4.0)",
Expand Down
2 changes: 1 addition & 1 deletion src/server/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"require": {
"php": "^8.4",
"psr/log": "^3.0",
"symfony/console": "^8.0",
"symfony/console": "^8.1",
"hypervel/contracts": "^0.4",
"hypervel/engine": "^0.4",
"hypervel/events": "^0.4",
Expand Down
2 changes: 1 addition & 1 deletion src/support/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"league/uri": "^7.5.1",
"nesbot/carbon": "^3.8.4",
"phpoption/phpoption": "^1.9",
"symfony/uid": "^8.0",
"symfony/uid": "^8.1",
"vlucas/phpdotenv": "^5.6.1",
"voku/portable-ascii": "^2.0.2",
"hypervel/bus": "^0.4",
Expand Down
2 changes: 1 addition & 1 deletion src/testbench/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"composer-runtime-api": "^2.2",
"mockery/mockery": "1.6.x-dev",
"phpunit/phpunit": "^13.0.3",
"symfony/yaml": "^8.0.12",
"symfony/yaml": "^8.1",
"vlucas/phpdotenv": "^5.6.1",
"hypervel/collections": "^0.4",
"hypervel/context": "^0.4",
Expand Down
Loading