Move header files to a top-level include folder#16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem is that the structure when building and installing is different, since they all get installed to
<prefix>/include/kaltestand this makes it so that many warnings appear in LCG stacks when building downstream packages (maybe not with Spack because they are not always underROOT_INCLUDE_PATH, while for LCG stacks they are):It's always searches following the structure from the source folders. There are multiple ways of fixing this, one of them not storing any paths and resolving through
ROOT_INCLUDE_PATH. I would say the changes here are less invasive because the content of the generated dictionaries is the same and it's probably a good idea; there are a total of 33 header files, and the existing distinction is maintained in the source files (plus includes were able to include from a different folder because everything was "global", so it's not like there are four independent pieces).BEGINRELEASENOTES
includefolderENDRELEASENOTES
The first two changes do not have any effect on the installed KalTest, only the third one changes from 4 dictionaries to a single one, but I think this is never used by name or I can't find any place where they are.