refactor: migrate resource_github_actions_environment_variable to tflog#3477
Open
texasich wants to merge 1 commit into
Open
refactor: migrate resource_github_actions_environment_variable to tflog#3477texasich wants to merge 1 commit into
texasich wants to merge 1 commit into
Conversation
|
👋 Hi, and thank you for this contribution! This repo is maintained by GitHub and community members on a best-effort basis. We'll get to this as soon as we can. You can help us prioritize by joining the discussion on open issues and PRs, sharing details on the changes you need, and reviewing other contributions. 🤖 This is an automated message. |
Collaborator
|
Please reopen #3325 instead of creating a new PR |
Author
3 tasks
Replace Go standard `log` package with HashiCorp structured `tflog` for consistent logging across the provider. Changes: - Replace `log` import with tflog import - Convert `log.Printf` to `tflog.Info` with structured fields Part of integrations#3070 Closes integrations#3325 Signed-off-by: texasich <101962694+texasich@users.noreply.github.com>
6c981b9 to
2ed3a2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Go standard
logpackage with HashiCorp structuredtflogfor consistent logging across the provider.Changes:
logimport with tflog importlog.Printftotflog.Infowith structured fieldsResolves #3070 (partial — this PR covers one file)
This is a resubmission of #3325 (was closed due to inactivity / capacity).
Before the change?
resource_github_actions_environment_variable.gouses Go's standardlog.Printffor logging, which produces unstructured output inconsistent with the rest of the provider.After the change?
Logging uses HashiCorp's
tflog.Infowith structured key-value fields (variable_id), consistent with the pattern established in other migrated files likeresource_github_membership.go.Pull request checklist