Github attestation for Open3D binaries#7512
Merged
Merged
Conversation
Copilot created this pull request from a session on behalf of
ssheorey
June 12, 2026 21:54
View session
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds GitHub artifact attestation generation across Open3D’s release-producing GitHub Actions workflows to provide cryptographic provenance for built artifacts.
Changes:
- Grants
id-token: writeandattestations: writepermissions to relevant workflow jobs. - Adds
actions/attest@v1steps for packages, wheels, viewers, and documentation artifacts. - Updates Windows viewer packaging to ZIP the viewer output before attesting and uploading.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/windows.yml | Adds attestations for devel package, viewer ZIP, and wheels; changes viewer packaging to create a ZIP prior to release update/upload. |
| .github/workflows/ubuntu.yml | Adds attestation generation for Linux devel package and viewer artifacts. |
| .github/workflows/ubuntu-wheel.yml | Adds attestation generation for CPU/GPU wheels prior to upload. |
| .github/workflows/ubuntu-sycl.yml | Adds attestation generation for SYCL wheel + devel package artifacts. |
| .github/workflows/ubuntu-openblas.yml | Adds wheel attestation generation prior to upload. |
| .github/workflows/ubuntu-cuda.yml | Adds package attestation generation prior to upload. |
| .github/workflows/macos.yml | Adds attestations for macOS packages, viewer ZIP, and wheels. |
| .github/workflows/documentation.yml | Adds attestation generation for the docs tarball prior to upload. |
…L_DIR and Join-Path
…NSTALL_DIR and paths
Copilot
AI
changed the title
Add GitHub artifact attestation support to release workflows
Fix env context logic and hardcoded paths in Ubuntu and Windows CI workflows
Jun 15, 2026
Member
ssheorey
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Type
Motivation and Context
The GitHub Actions workflow files for Ubuntu and Windows contained non-robust context assumptions and hardcoded paths that can lead to skipped attestation steps or build drift if folder structures change. This PR resolves these workflow robustness issues.
Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
This pull request addresses Copilot reviews for CI workflow configuration reliability:
Ubuntu Workflow Improvements
env.BUILD_SHARED_LIBSreferences in stepif:expressions withmatrix.BUILD_SHARED_LIBSdirectly in.github/workflows/ubuntu.yml. This ensures conditionals evaluate correctly even when env variables are not fully exported/populated at step initialization.Windows Workflow Improvements
INSTALL_DIRenvironment variable to represent the target installation prefix path (C:\Program Files\Open3D), removing hardcoded literal paths.CMakeCache.txt(C:/Open3D/build/CMakeCache.txt) by dynamically resolving it using$env:BUILD_DIRwith PowerShell'sJoin-Pathcmdlet.$env:INSTALL_DIR/${{ env.INSTALL_DIR }}) across target install configurations, ZIP archives, and cleanup routines.For example, CMakeCache.txt and directory compression paths are now constructed dynamically: