Conversation
impurity_solver.name help text listed only 6 of the registered solvers; add HPhi, JO/cthyb-seg and scipy/sparse so the auto-generated option table matches impurity_solvers.solver_classes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
k-yoshimi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
impurity_solver.namehelp text listed only 6 of the registered solvers (null, TRIQS/cthyb, TRIQS/hubbard-I, ALPS/cthyb, ALPS/cthyb-seg, pomerol). Added the missingHPhi,JO/cthyb-seg, andscipy/sparseso the auto-generated option table matchesimpurity_solvers.solver_classes.(An earlier revision also linked the spin_orbit/openmx/respack tutorial pages into the toctree, but those were intentionally excluded, so that change was dropped.)
Notes (not in this PR — need maintainer/domain input)
doc/impuritysolvers/triqs_cthyb/cthyb.rststill documentsperform_tail_fit/fit_*under[system], but[system]does notallow_undefined_options, so those keys now raise a parse error (the current control is theno_tail_fitboolean). A correct fix needs a rewrite of the tail-fit / Legendre sections against the current TRIQS/cthyb capabilities.dcore_bse+[bse]) still have no reference/tutorial pages.🤖 Generated with Claude Code