B-Prod-P2: FrsSnapshot + MVCC linker bindings (depends on P1 + ForSt P2)#2
Open
jackylee-ch wants to merge 1 commit into
Open
B-Prod-P2: FrsSnapshot + MVCC linker bindings (depends on P1 + ForSt P2)#2jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
…nker bindings
Task 2.5 — FrsSnapshot Java type
* `FrsSnapshot` AutoCloseable wrapper over the native FrsSnapshot
pointer; `close()` is idempotent (per spec §10.0 ABI lifetime
contract); `handle()` throws IllegalStateException after close so
use-after-close fails fast on the Java side rather than corrupting
the native registry.
* `ForStRsLinker.dbSnapshot(db, arena)` mints a snapshot;
`ForStRsLinker.dbReleaseSnapshot(db, snapshot)` is package-private
and routed through `FrsSnapshot.close()` so callers always go through
the AutoCloseable contract.
* 4 unit tests in `FrsSnapshotTest`: round-trip, double-close-safe,
try-with-resources release, post-close handle access throws.
Task 2.6 — Linker bindings for getAt / iteratorOpenAt / incremental ckpt
* `getAt(db, cf, snapshot, key)` — versioned point-lookup; bound
critical-mode like `get` for hot-path zero-copy. Returns null on
NOT_FOUND.
* `iteratorOpenAt(db, cf, snapshot, arena)` — versioned forward
iterator that yields the latest version of each user-key with
seq <= snapshot.seq.
* `createIncrementalCheckpointAt(db, snapshot, ckptId, baseId, resultPtr)`
+ `dbIncrementalCheckpointResultFree(resultPtr)` — caller stages the
32-byte FrsIncrementalCheckpointResult struct in their own arena
and frees the inner allocations via the dedicated free helper.
* `dbOpenFromIncremental(arena, targetDir, baseManifest, sstFiles)`
— restore-side counterpart that builds the per-call C-string array
in a confined arena.
* 2 new tests in `ForStRsLinkerExtendedTest`:
`snapshotIsolationAcrossFfmHop` (write v1 → snapshot → write v2;
getAt sees v1 while normal get sees v2) and
`iteratorOpenAtFiltersBySnapshotSeq` (3 keys before snapshot + 1
after; iter yields exactly the 3 pre-snapshot keys).
Combined into a single commit because the linker bindings for 2.5 and
2.6 are interleaved in `ForStRsLinker.java` (single MethodHandle field
section + single constructor binding block) and splitting would
fragment the §8 module surface.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per spec §10.0 / §10a / §10b. Depends on ForSt P2 (Rust FFI exports) and P1 (Flink keyed-backend skeleton).
This PR ships the JDK 25 FFM Java bindings for the new MVCC + incremental-checkpoint surface that ForSt P2 added.
Tasks 2.5-2.6 covered
Bundled into a single commit because the linker bindings for 2.5 and 2.6 are interleaved in `ForStRsLinker.java` (single MethodHandle field section + single constructor binding block) and splitting would fragment the §8 module surface.
Test plan
🤖 Generated with Claude Code