ecto - fix: add wrangler as devDependency for deploy workflow#377
Merged
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 413 413
Branches 96 96
=========================================
Hits 413 413 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add wrangler to devDependencies so wrangler-action uses the project-installed version instead of running pnpm add at deploy time - Add sharp to allowBuilds (wrangler dependency) - Add rolldown and @rolldown/binding-* to minimumReleaseAgeExclude (platform-specific binaries published in batch with each rolldown release) - Revert packageManager: npm workaround from deploy workflow
jaredwray
force-pushed
the
fix/deploy-wrangler-packagemanager
branch
from
3b4bd1a to
396ad11
Compare
jaredwray
changed the title
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
jaredwray
commented
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix deploy-site workflow failure caused by
wrangler-action@v4runningpnpm add wrangler@4at deploy time, which fails the project'sminimumReleaseAgegate on transitive dependencies.Fix
wranglertodevDependenciesso wrangler-action finds it already installedsharptoallowBuildsinpnpm-workspace.yaml(wrangler dependency with build scripts)rolldownand@rolldown/binding-*tominimumReleaseAgeExclude— these are platform-specific native binaries batch-published with each rolldown release; the age check doesn't add meaningful security value for native binary packages tied to a known build toolchain dependency (vite)Verification
pnpm install --frozen-lockfilesucceedspnpm buildpassespnpm testpasses (237 tests, 100% coverage)