fix: remove post-render entity on handlebars#379
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the ent and @types/ent dependencies and eliminates post-render entity decoding from the Handlebars engine. This aligns the engine with standard Handlebars semantics, where {{var}} HTML-escapes and {{{var}}} inserts raw HTML, preventing issues where legitimately escaped content was corrupted. Corresponding tests have been updated and new test cases added to verify correct escaping behavior. There are no review comments, so I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 413 409 -4
Branches 96 96
=========================================
- Hits 413 409 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fix: remove post-render entity on handlebars