Skip to content

fix: remove post-render entity on handlebars#379

Merged
jaredwray merged 1 commit into
mainfrom
fix-remove-post-render-entity-on-handlebars
Jun 11, 2026
Merged

fix: remove post-render entity on handlebars#379
jaredwray merged 1 commit into
mainfrom
fix-remove-post-render-entity-on-handlebars

Conversation

@jaredwray

@jaredwray jaredwray commented Jun 11, 2026

Copy link
Copy Markdown
Owner

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fix: remove post-render entity on handlebars

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the ent and @types/ent dependencies and eliminates post-render entity decoding from the Handlebars engine. This aligns the engine with standard Handlebars semantics, where {{var}} HTML-escapes and {{{var}}} inserts raw HTML, preventing issues where legitimately escaped content was corrupted. Corresponding tests have been updated and new test cases added to verify correct escaping behavior. There are no review comments, so I have no feedback to provide.

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (11c920a) to head (b32cc50).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #379   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          413       409    -4     
  Branches        96        96           
=========================================
- Hits           413       409    -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray jaredwray merged commit f4d9790 into main Jun 11, 2026
11 checks passed
@jaredwray jaredwray deleted the fix-remove-post-render-entity-on-handlebars branch June 11, 2026 20:03
@jaredwray jaredwray mentioned this pull request Jun 25, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant