root - chore: upgrade hookified to v3 (breaking)#385
Conversation
Bump the hookified events/hooks base across a major version. - hookified 2.2.0 -> 3.0.0 Per hookified's v2->v3 migration guide, v3 has no API changes; the only breaking change is the minimum Node.js version, now >=22.18.0 (Node 20 reached end-of-life April 2026). ecto targets Node 24 via .nvmrc and runs CI on Node 22/24/26, so it is unaffected. ecto extends Hookified and uses emit/hook/hookSync/HookifiedOptions, all unchanged in v3. pnpm build and all 239 tests pass with 100% coverage, no code changes required. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013MMsnH2H2ghs6xLGibb5v2
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request upgrades the hookified dependency from ^2.2.0 to ^3.0.0. The reviewer notes that hookified v3 requires Node.js >=22.18.0, which is a breaking change. To prevent runtime failures for consumers on older Node.js versions, it is recommended to declare this requirement in the engines field of package.json.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 409 409
Branches 96 96
=========================================
Hits 409 409 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hookified v3 raises the minimum supported Node.js to >=22.18.0. Declare it in engines so consumers on older Node are warned at install time rather than hitting runtime failures. Addresses review feedback on PR #385. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013MMsnH2H2ghs6xLGibb5v2
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d628ef27de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Upgrade the
hookifiedevents/hooks base class across a major version. Runtime-phase PR.Versions
hookified2.2.0→3.0.0Tests
pnpm buildpassespnpm testpasses (239 tests, 100% coverage) — no code changes requiredBreaking notes
Per hookified's own v2→v3 migration guide: v3 has no API changes. The only breaking change is the minimum Node.js version, now
>=22.18.0(Node 20 reached end-of-life in April 2026).ecto targets Node 24 via
.nvmrcand runs CI on Node 22/24/26, so it is unaffected.EctoextendsHookifiedand usesemit/hook/hookSync/HookifiedOptions, all unchanged in v3.Notes
After this merges, the only remaining outdated items are intentionally held back, not actionable:
writr6.1.3 — deferred bytrustPolicy: no-downgrade(missing provenance attestation on writr 6.1.2/6.1.3 viadocula@2.0.0).tsdown0.22.3 — deferred byminimumReleaseAge(transitive@napi-rs/wasm-runtime).@types/node— capped at major 24 per.nvmrc.🤖 Generated with Claude Code
Generated by Claude Code