Skip to content

root - chore: upgrade hookified to v3 (breaking)#385

Merged
jaredwray merged 2 commits into
mainfrom
claude/ecto-dependency-maintenance-n8yajd
Jun 25, 2026
Merged

root - chore: upgrade hookified to v3 (breaking)#385
jaredwray merged 2 commits into
mainfrom
claude/ecto-dependency-maintenance-n8yajd

Conversation

@jaredwray

Copy link
Copy Markdown
Owner

Summary

Upgrade the hookified events/hooks base class across a major version. Runtime-phase PR.

Versions

  • hookified 2.2.03.0.0

Tests

  • pnpm build passes
  • pnpm test passes (239 tests, 100% coverage) — no code changes required

Breaking notes

Per hookified's own v2→v3 migration guide: v3 has no API changes. The only breaking change is the minimum Node.js version, now >=22.18.0 (Node 20 reached end-of-life in April 2026).

ecto targets Node 24 via .nvmrc and runs CI on Node 22/24/26, so it is unaffected. Ecto extends Hookified and uses emit / hook / hookSync / HookifiedOptions, all unchanged in v3.

Notes

After this merges, the only remaining outdated items are intentionally held back, not actionable:

  • writr 6.1.3 — deferred by trustPolicy: no-downgrade (missing provenance attestation on writr 6.1.2/6.1.3 via docula@2.0.0).
  • tsdown 0.22.3 — deferred by minimumReleaseAge (transitive @napi-rs/wasm-runtime).
  • @types/node — capped at major 24 per .nvmrc.

🤖 Generated with Claude Code


Generated by Claude Code

Bump the hookified events/hooks base across a major version.

- hookified 2.2.0 -> 3.0.0

Per hookified's v2->v3 migration guide, v3 has no API changes; the only
breaking change is the minimum Node.js version, now >=22.18.0 (Node 20
reached end-of-life April 2026). ecto targets Node 24 via .nvmrc and runs
CI on Node 22/24/26, so it is unaffected.

ecto extends Hookified and uses emit/hook/hookSync/HookifiedOptions, all
unchanged in v3. pnpm build and all 239 tests pass with 100% coverage, no
code changes required.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013MMsnH2H2ghs6xLGibb5v2
@socket-security

socket-security Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedhookified@​3.0.010010010091100

View full report

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the hookified dependency from ^2.2.0 to ^3.0.0. The reviewer notes that hookified v3 requires Node.js >=22.18.0, which is a breaking change. To prevent runtime failures for consumers on older Node.js versions, it is recommended to declare this requirement in the engines field of package.json.

Comment thread package.json
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d3e2749) to head (5f72cd3).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #385   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          409       409           
  Branches        96        96           
=========================================
  Hits           409       409           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hookified v3 raises the minimum supported Node.js to >=22.18.0. Declare it
in engines so consumers on older Node are warned at install time rather
than hitting runtime failures.

Addresses review feedback on PR #385.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013MMsnH2H2ghs6xLGibb5v2

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d628ef27de

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
@jaredwray jaredwray merged commit e818163 into main Jun 25, 2026
11 checks passed
@jaredwray jaredwray deleted the claude/ecto-dependency-maintenance-n8yajd branch June 25, 2026 16:35
@jaredwray jaredwray mentioned this pull request Jun 25, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants