respect marginality in response surface stepwise selection#487
Open
JohnnyDoorn wants to merge 3 commits into
Open
respect marginality in response surface stepwise selection#487JohnnyDoorn wants to merge 3 commits into
JohnnyDoorn wants to merge 3 commits into
Conversation
step() treats I(x^2) as unrelated to x, so it could keep a squared term without its main effect. Re-add missing main effects and refit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
👋 Friendly reminder: It looks like If your changes include bug fixes, new features, or UI tweaks, please consider adding a quick note to the |
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #487 +/- ##
==========================================
- Coverage 84.96% 84.22% -0.75%
==========================================
Files 18 18
Lines 10012 10410 +398
==========================================
+ Hits 8507 8768 +261
- Misses 1505 1642 +137 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Comment on lines
+22
to
+23
| .enforceSquaredTermMarginality <- function(model, | ||
| data = eval(stats::getCall(model)[["data"]], environment(stats::formula(model)))) { |
Comment on lines
+1650
to
+1653
| message <- sprintf(ngettext(length(forcedMainEffects), | ||
| "The main effect %s was retained to respect marginality (its squared term is in the model).", | ||
| "The main effects %s were retained to respect marginality (their squared terms are in the model)."), | ||
| paste(forcedMainEffects, collapse=", ")) |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
step() treats I(x^2) as unrelated to x, so it could keep a squared term without its main effect. Re-add missing main effects and refit.
Fix https://github.com/jasp-stats/INTERNAL-jasp/issues/3265
Fix https://github.com/jasp-stats/INTERNAL-jasp/issues/3218