Skip to content

add timeout for keepalive reply#442

Closed
ximiximi1 wants to merge 2 commits into
jpillora:masterfrom
ximiximi1:sshkeepalive-patch
Closed

add timeout for keepalive reply#442
ximiximi1 wants to merge 2 commits into
jpillora:masterfrom
ximiximi1:sshkeepalive-patch

Conversation

@ximiximi1

Copy link
Copy Markdown

The sshConn.Send Request will send message and block wait the reply.
The keepalive will not work in some special condition. For example, when the server use memory snapshot to hibernate and did not close the socket normally and there is a websocket middware like Cloudflare to proxy the websocket, when the server hibernate with memory snapshot, Cloudflare will not close the websocket connection during a very long time(this maybe a issue of Cloudflare), in the mean while, the keepalive block wait the reply(there will not have a reply as server hibernated), as a result, the ssh connection will not close until the Cloudflare close the websocket(very long time above 10min).
So I add a reply timeout for the keepalive. A timeout error will raise when wait the keepalive reply too long, and then close the ssh connetion.

@jpillora

Copy link
Copy Markdown
Owner

Thanks this is a good change - will try get a sec to test it soon

@linus-gates

Copy link
Copy Markdown

Hey, Is this going to merge anytime soon? Thanks!!

@OS-kiranmalsetty

Copy link
Copy Markdown

@jpillora We are experiencing the same issues described here, and this PR will resolve them. Could you please review and merge the PR?

@dedosmedia

Copy link
Copy Markdown

Please I need this feature in a future release! 🙏

terminar added a commit to terminar/chisel that referenced this pull request Sep 18, 2024
@jpillora

Copy link
Copy Markdown
Owner

Thanks for working on this! A fix for the blocking keepalive ping has been implemented based on the approach in #581 (ping raced against a timeout, with a CHISEL_PING_TIMEOUT override) and will ship in the next release. Closing as superseded.

@jpillora jpillora closed this Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants