🎨 Palette: Restore not-allowed cursor on disabled elements with tooltips#49
🎨 Palette: Restore not-allowed cursor on disabled elements with tooltips#49jspann21 wants to merge 1 commit into
Conversation
Added `cursor-not-allowed` dynamically to wrapper `DisabledTooltip` components when the inner button is disabled. Kept `pointer-events-none` on the buttons so that hover states are bypassed and tooltips continue to catch pointer events correctly. Co-authored-by: jspann21 <179991454+jspann21@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What
Added
cursor-not-alloweddynamically to the wrapperDisabledTooltipcomponent when the wrapped button is disabled.🎯 Why
Previously, applying
pointer-events-noneto disabled buttons completely prevented hover events, destroying thecursor: not-allowedindicator. If we just blindly swap the button's class, we break wrapper tooltips that rely on swallowing pointer events to display the disabled reason! By targeting the wrapper component specifically when it's wrapping a disabled child, we maintain standard tooltips and also restore the visually indicative cursor for a polished micro-UX experience.📸 Before/After
Before: Hovering over the disabled "Export/Import" buttons or "Add Folder" inputs did not change the cursor, leaving it as the default arrow even though the action is unavailable.
After: Hovering gracefully shows the "not-allowed" circle-slash cursor alongside the tooltip.
♿ Accessibility
Enhances visual feedback for interactable elements, making the interface state immediately clearer to mouse users navigating the interface without conflicting with tooltip screen reader support.
PR created automatically by Jules for task 12054175263287617448 started by @jspann21