🎨 Palette: Add disabled cursor to buttons with tooltips#50
Conversation
Applies `cursor-not-allowed` to the wrapper elements of disabled buttons that have tooltips. This ensures the disabled cursor state is correctly displayed to the user when hovering over them, while maintaining the tooltips. Affected buttons: - Add Books (LibraryHeader) - Save Changes (BookDetailsPanel) - Rescan metadata (BookDetailsPanel) - Open file (BookDetailsPanel) - Hide from library (BookDetailsPanel) - Delete book (BookDetailsPanel) Co-authored-by: jspann21 <179991454+jspann21@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Added
cursor-not-allowedutility classes conditionally to the wrapperspanelements of several disabled buttons that have tooltips.🎯 Why: In Tailwind CSS, setting
pointer-events-noneon a disabled button hides the standard disabled cursor state and breaks hover triggers, meaning tooltips can't be placed directly on the button. While wrapping the button in aspanfixes the tooltip, it still lacks the proper "disabled" cursor feedback. Applying the class to the wrapper restores this standard UX behavior.📸 Before/After:
(Visual change verified locally via Playwright script: hovering over the disabled "Add Books" button now shows the proper crossed-circle cursor while still showing the tooltip).
♿ Accessibility: Provides clear visual feedback for mouse users that an action is currently unavailable, reducing confusion when clicking seems to do nothing.
PR created automatically by Jules for task 6978906251326342939 started by @jspann21