🎨 Palette: Add cursor-not-allowed to disabled tooltipped elements#52
🎨 Palette: Add cursor-not-allowed to disabled tooltipped elements#52jspann21 wants to merge 1 commit into
Conversation
In Tailwind CSS, applying `pointer-events-none` directly to a disabled button prevents `cursor-not-allowed` from functioning correctly on hover. For buttons with a tooltip wrapper (`<span>`), we must conditionally apply `cursor-not-allowed` to the wrapper. This commit adds this class to wrapper elements in `App.tsx`, `LibraryHeader.tsx`, and `BookDetailsPanel.tsx`. Co-authored-by: jspann21 <179991454+jspann21@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Added
cursor-not-allowedconditional class to wrapper<span>elements around disabled buttons that have tooltips.🎯 Why: Disabled buttons rely on wrapper elements to show tooltips (as
pointer-events-noneon the button itself prevents mouse events). Because of this, the standard disabled cursor was missing. This change adds the expected visual feedback back to the wrappers.📸 Before/After: Visual changes can be observed when hovering over disabled elements like the zoom buttons, "Add Books" while scanning, and several disabled actions in the
BookDetailsPanel.♿ Accessibility: Improved visual feedback for users indicating when actions are not currently possible while maintaining existing tooltip explanations.
PR created automatically by Jules for task 15260132600297524548 started by @jspann21