Skip to content

🎨 Palette: Add disabled cursor to action buttons#53

Open
jspann21 wants to merge 1 commit into
mainfrom
palette/tooltip-disabled-cursors-13268461503833705442
Open

🎨 Palette: Add disabled cursor to action buttons#53
jspann21 wants to merge 1 commit into
mainfrom
palette/tooltip-disabled-cursors-13268461503833705442

Conversation

@jspann21

Copy link
Copy Markdown
Owner

💡 What: Added dynamic cursor-not-allowed Tailwind classes to the span wrappers of various disabled action buttons across the library UI (Add Books, Save Changes, Rescan, Open File, Hide, Delete).

🎯 Why: In our current setup, disabled buttons have pointer-events-none applied via the disabled:pointer-events-none utility class. This natively prevents any pointer events from being fired by the button, intrinsically disabling the CSS cursor-not-allowed style applied directly to the button itself. Users received no visual hover feedback that an action was disabled. To fix this, the disabled cursor state must be applied to the wrapper element instead.

📸 Before/After: Visual changes only noticeable via hover states. When hovering over disabled buttons, the cursor now changes to the 'not allowed' circle-slash indicator.

♿ Accessibility: Clearer visual communication of application state. Users who rely on hover feedback will easily recognize when an action is unavailable.


PR created automatically by Jules for task 13268461503833705442 started by @jspann21

Apply `cursor-not-allowed` dynamically to the spans wrapping disabled
buttons in `LibraryHeader.tsx` and `BookDetailsPanel.tsx`. This ensures
the disabled cursor state is visible even when the button has
`pointer-events-none`.

Co-authored-by: jspann21 <179991454+jspann21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant