⚡ Bolt: Prevent O(N) Re-renders on Virtualized Book Selection#55
⚡ Bolt: Prevent O(N) Re-renders on Virtualized Book Selection#55jspann21 wants to merge 1 commit into
Conversation
Replaces the React prop-driven visibility toggle in the virtualized book list with a CSS descendant selector approach. This prevents O(N) full-list re-renders when activating bulk selection mode, shifting the visual update entirely to the browser's style engine. Co-authored-by: jspann21 <179991454+jspann21@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Replaced the
selectionModeActiveprop passed down to every<LibraryBookCard>with a parent-levelselection-mode-activeCSS class and applied Tailwind descendant selectors ([.selection-mode-active_&]:opacity-100) to the checkboxes.🎯 Why: Previously, toggling selection mode required React to re-render every visible item in the virtualized grid to update the
selectionModeActiveprop, creating an O(N) render bottleneck. Moving this logic to CSS preserves component memoization.📊 Impact: Reduces React re-renders from O(N) to O(1) when activating bulk selection, making the interaction instantaneous regardless of list size.
🔬 Measurement: Verified via Playwright that checkboxes correctly appear when the parent container applies the selection class. Linting and testing also pass.
PR created automatically by Jules for task 9181006600989749985 started by @jspann21